fix: consider exclueded file in COPY --from cache keys #2615

[massimeddu-sj]

Fixes #2615

Description

This PR consider excluded files when kaniko calculates the cache key for COPY --from command.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• [ ] Includes unit tests
• [ ] Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

• [ ] The code flow looks good.
• [ ] Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[aaron-prindle]

Thanks for the PR here @massimeddu-sonicjobs! Seems currently there is an error when linting the go code:

field `considerExcludedFiles` is unused (unused)

[edwardsmit]

Hi @massimeddu-sonicjobs thank you for creating this PR. I was wondering if you are planning to work on this PR in the near future? If you aren't, would you mind if I take a stab at fixing this PR?

[edwardsmit]

@aaron-prindle Do you support the general flow of this PR? If not, I'd keen to know before I take a stab at driving this home.

[massimeddu-sj]

Hi @massimeddu-sonicjobs thank you for creating this PR. I was wondering if you are planning to work on this PR in the near future? If you aren't, would you mind if I take a stab at fixing this PR?

Hi @edwardsmit , unfortunately I cannot further work on this in the near future. Feel free to review and improve this PR if you want.

[rgschmitz1]

I'm wondering if there's anyone currently working on this PR? I have experienced issues with multistage build cache that might be related.

[edwardsmit]

I'm currently not. So feel free to pick it up as @massimeddu-sj isn't working on this either.

[braykov]

Why is this still being ignored? It's a bug that impacts multi-stage builds still.

[rgschmitz1]

Why is this still being ignored? It's a bug that impacts multi-stage builds still.

I had intended on working on this but I'm not a golang developer and it would take some personal time to learn. If time is money, then I'm broke.

Kaniko is an open-source project, developers volunteer time their time to write and fix code (typically no one pays for this).