jib icon indicating copy to clipboard operation
jib copied to clipboard

Allow configuring enablePlatformTags via plugins

Open eifinger opened this issue 2 years ago • 5 comments

Thank you for your interest in contributing! For general guidelines, please refer to the contributing guide.

Before filing a pull request, make sure to do the following:

  • [x] Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose.
  • [x] Ensure that your implementation plan is approved by the team.
  • [x] Verify that integration tests and unit tests are passing after the change.
  • [x] Address all checkstyle issues. Refer to the style guide.

This helps to reduce the chance of having a pull request rejected.

Fixes #3518🛠️

This PR tries to pick up https://github.com/GoogleContainerTools/jib/pull/3710 I added the requested integration test testSteps_forBuildToDockerRegistry_multiplePlatforms

eifinger avatar Jun 01 '23 06:06 eifinger

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 01 '23 06:06 google-cla[bot]

Is there anything I can do to get the conversation started?

eifinger avatar Jun 13 '23 21:06 eifinger

Maybe this is something you could look at @mpeddada1 ?

msvticket avatar Feb 22 '24 11:02 msvticket

Is their any update or status of this MR?

cholmes-axoni avatar Jul 01 '24 18:07 cholmes-axoni