jib icon indicating copy to clipboard operation
jib copied to clipboard

Allow configuring enablePlatformTags via plugins.

Open tylerscoville opened this issue 3 years ago • 5 comments

Continuation of https://github.com/GoogleContainerTools/jib/issues/3518

I'm interested in being able to configure enablePlatformTags via the gradle plugin. I think this is the path to do that as described in https://github.com/GoogleContainerTools/jib/pull/3523#issuecomment-1050424524.

tylerscoville avatar Jul 20 '22 21:07 tylerscoville

Thank you for following up on the contribution @tylerscoville! We will review this week.

mpeddada1 avatar Jul 25 '22 14:07 mpeddada1

@mpeddada1 Thanks for having a look! I pushed some changes to try and up test coverage and clean up the commit history.

tylerscoville avatar Jul 27 '22 16:07 tylerscoville

@tylerscoville Thanks again! I've added a few comments. Let me know if you have any questions!

mpeddada1 avatar Aug 01 '22 17:08 mpeddada1

@mpeddada1 @elefeint Thank you for the review! Sorry it took me so long to get back to this.

tylerscoville avatar Aug 09 '22 22:08 tylerscoville

@tylerscoville THANKS!

I went back and looked at attempting this twice. I kept getting lost in the configuration chain. And the job kept getting me distracted with work things.

I'm still trying to get some other dependencies updated so I can get to multi-arch. Do you need any help on this?

ghost avatar Oct 31 '22 21:10 ghost

Looks like adding the new method to RawConfiguration interface broke maven compilation --

Task :jib-maven-plugin:compileJava FAILED /home/runner/work/jib/jib/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenRawConfiguration.java:30: error: MavenRawConfiguration is not abstract and does not override abstract method getEnablePlatformTags() in RawConfiguration public class MavenRawConfiguration implements RawConfiguration {

I defaulted the RawConfiguration to return false. Hopefully this gets us past that error 🤞

tylerscoville avatar Mar 09 '23 23:03 tylerscoville

@elefeint @mpeddada1 Sorry about the long delay on this. Let me know if there is anything else I can do!

tylerscoville avatar Mar 14 '23 16:03 tylerscoville