jib icon indicating copy to clipboard operation
jib copied to clipboard

Published 20 hours ago • verified publisher icon GoogleContainerTools

Upgrade workflow to run unit tests in Java 17 - the latest LTS

Open yrashish opened this issue 4 years ago • 6 comments

Java 16 is GA. Let me know if we can upgrade the workflow yml file to include JDK 16 also as part of running the unit test.

yrashish avatar Mar 16 '21 18:03 yrashish

Sure thing! Will be interesting to see if it works. (I expect it will.)

chanseokoh avatar Mar 16 '21 20:03 chanseokoh

But probably we will replace 16 with 17 (instead of just adding 17) when it gets out. For efficiency, we don't want to test on every Java version. Probably only LTS versions.

chanseokoh avatar Mar 16 '21 20:03 chanseokoh

So can I make the change?. I understand that it's much efficient to stick with the LTS version. Still, In my opinion, it would be good to have at least one or two non-LTS versions for unit tests to understand compatibility with different JDK versions. Thoughts?

yrashish avatar Mar 18 '21 16:03 yrashish

Sure, go ahead. I was just mentioning that when 17 comes out, we will probably drop 16.

chanseokoh avatar Mar 18 '21 18:03 chanseokoh

Modified the title to "Upgrade workflow to java 17 (the latest LTS) "

ddixit14 avatar Aug 02 '22 17:08 ddixit14

This seems urgent due to sonarcloud warning

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarsource.com/sonarcloud/appendices/scanner-environment/)

Prerequisite is update to a Gradle version that supports Java 17 (cf https://docs.gradle.org/current/userguide/compatibility.html#java): https://github.com/GoogleContainerTools/jib/pull/4139

rquinio avatar Nov 19 '23 13:11 rquinio