jib icon indicating copy to clipboard operation
jib copied to clipboard

Published 20 hours ago • verified publisher icon GoogleContainerTools

Enhance RegistryClient tests

Open briandealwis opened this issue 5 years ago • 2 comments

We should have tests around the RegistryClient network requests. Maybe can make TestWebServer take a list of expect-response pairs.

Originally posted by @briandealwis in https://github.com/GoogleContainerTools/jib/pull/1793/review_comment/create

briandealwis avatar Jun 24 '19 20:06 briandealwis

Sounds good. Just don't start working on this now; I have a branch modifying TestWebServer that I was planning to push at some far point in the future, and I think I should push that now.

chanseokoh avatar Jun 24 '19 20:06 chanseokoh

@louismurerwa some tests we can add:

  • RegistryClient.pullManifest()
  • RegistryClient.pushManifest()
  • RegistryClient.checkBlob()
  • RegistryClient.pullBlob()
  • RegistryClient.pushBlob()

chanseokoh avatar Jun 29 '20 16:06 chanseokoh