distroless icon indicating copy to clipboard operation
distroless copied to clipboard

Add option in cacerts rules to include additional ca certs

Open dpoll opened this issue 6 years ago • 12 comments

This features allow adding additional ca certificates in the cacerts rule. This is useful when ca certs are needed which are not part of the ca-certificates Debian package.

dpoll avatar Jan 07 '19 23:01 dpoll

The merge conflict should be resolved first before this can be reviewed.

chanseokoh avatar Jan 07 '20 15:01 chanseokoh

@dpoll any update on this?

christopherhein avatar Jun 08 '20 18:06 christopherhein

any updates please on this ?

OuadiaGamrane avatar Sep 07 '21 10:09 OuadiaGamrane

Hrmm, yeah I can take a look, @dpoll would you like to clean up this PR? @OuadiaGamrane / @christopherhein you're also welcome to create a new PR with the changes against the current main branch.

loosebazooka avatar Sep 22 '21 18:09 loosebazooka

Any updates on this? It's been over 2 years since PR was created...

gaby avatar Jan 16 '22 16:01 gaby

Friendly bump @dpoll @loosebazooka

gaby avatar Jan 16 '22 16:01 gaby

@gaby we always encourage users to create a new pr of this is pressing for them

loosebazooka avatar Jan 16 '22 17:01 loosebazooka

@loosebazooka I don't really understand how to apply the changes from this PR into a new one since the extract.sh is nowhere to be found. I'd say to close this since @dpoll is not even active on Github.

gaby avatar Jan 16 '22 22:01 gaby

Hey, sorry for my super slow response. I just tried to fix the conflict. Not sure if it works correctly since I can't remember how I tested this before. I'll push what I have later today.

dpoll avatar Jan 16 '22 23:01 dpoll

I merged in main tried get the feature working with all the changes but I'm having some issue. I pushed the changes but test.sh is still not passing for me, I think there is some issue with the way the file paths argument is getting passed in.

I'm not sure what the fix is here. If someone has some idea how to help me that would be great, or go ahead and make the change yourself.

dpoll avatar Jan 17 '22 05:01 dpoll

is this still needed?

xcheng75 avatar Jun 27 '22 23:06 xcheng75

@xcheng75 Yes, specially for corporate networks, and airgap networks.

gaby avatar Jun 28 '22 01:06 gaby

So this PR is just extremely out of date at this point. If anyone wants to redo it for the new repo structure, please create a new PR and I will review it.

loosebazooka avatar May 02 '23 19:05 loosebazooka