distroless feat: migrate to bzlmod

Migrating to bzlmod, needs https://github.com/GoogleContainerTools/rules_distroless/pull/70 first.

Aug 09 '24 00:08 thesayyn

I think the node references are gone?

Aug 09 '24 14:08 loosebazooka

I think the node references are gone?

no those went into private/extensions/

Aug 09 '24 17:08 thesayyn

oh I see, well maybe a name got mangled? : https://github.com/GoogleContainerTools/distroless/actions/runs/10311366649/job/28544819823?pr=1640#step:6:57

Aug 09 '24 19:08 loosebazooka

oh I see, well maybe a name got mangled? : https://github.com/GoogleContainerTools/distroless/actions/runs/10311366649/job/28544819823?pr=1640#step:6:57

right, there was an issue in the extension, fixed now.

Aug 09 '24 20:08 thesayyn

🌳 🔄 Image Check

This pull request has modified the following images:

//base:static_root_amd64_debian12
//base:static_debug_root_amd64_debian12
//base:static_nonroot_arm64_debian12
//base:static_nonroot_arm_debian12
//base:static_debug_root_arm_debian12
//base:static_nonroot_s390x_debian12
//base:static_debug_root_ppc64le_debian12
//base:static_debug_nonroot_ppc64le_debian12
//base:static_root_arm_debian12
//base:base_root_amd64_debian12
//base:static_debug_root_arm64_debian12
//base:static_root_s390x_debian12
//base:base_root_arm64_debian12
//base:static_nonroot_amd64_debian12
//base:debug_nonroot_arm64_debian12
//base:debug_nonroot_amd64_debian12
//base:base_nonroot_amd64_debian12
//base:base_nonroot_arm64_debian12
//base:base_root_arm_debian12
//base:static_debug_nonroot_s390x_debian12
//base:debug_root_arm_debian12
//base:debug_root_amd64_debian12
//base:base_nonroot_s390x_debian12
//base:base_root_s390x_debian12
//base:static_nonroot_ppc64le_debian12
//base:static_debug_nonroot_arm64_debian12
//base:debug_nonroot_arm_debian12
//base:debug_root_ppc64le_debian12
//base:base_nonroot_ppc64le_debian12
//base:base_nonroot_arm_debian12
//base:debug_root_s390x_debian12
//base:base_nossl_root_amd64_debian12
//base:base_root_ppc64le_debian12
//base:base_nossl_root_arm64_debian12
//base:base_nossl_nonroot_arm64_debian12
//base:base_nossl_nonroot_amd64_debian12
//base:debug_nonroot_ppc64le_debian12
//base:base_nossl_root_arm_debian12
//base:static_root_ppc64le_debian12
//base:static_debug_root_s390x_debian12
//base:static_root_arm64_debian12
//base:base_nossl_debug_root_arm_debian12
//base:debug_nonroot_s390x_debian12
//base:base_nossl_debug_nonroot_amd64_debian12
//base:static_debug_nonroot_amd64_debian12
//base:base_nossl_debug_nonroot_arm64_debian12
//base:base_nossl_nonroot_s390x_debian12
//base:base_nossl_debug_root_amd64_debian12
//base:base_nossl_nonroot_ppc64le_debian12
//base:debug_root_arm64_debian12
//base:base_nossl_debug_nonroot_s390x_debian12
//base:base_nossl_debug_root_s390x_debian12
//cc:debug_nonroot_amd64_debian12
//base:static_debug_nonroot_arm_debian12
//cc:cc_nonroot_arm64_debian12
//cc:cc_nonroot_amd64_debian12
//base:base_nossl_root_s390x_debian12
//cc:cc_root_amd64_debian12
//cc:debug_root_amd64_debian12
//base:base_nossl_debug_nonroot_ppc64le_debian12
//cc:cc_root_s390x_debian12
//base:base_nossl_debug_nonroot_arm_debian12
//base:base_nossl_nonroot_arm_debian12
//cc:debug_root_arm64_debian12
//base:base_nossl_debug_root_ppc64le_debian12
//cc:debug_root_arm_debian12
//cc:debug_nonroot_arm_debian12
//base:base_nossl_debug_root_arm64_debian12
//cc:debug_nonroot_ppc64le_debian12
//cc:cc_nonroot_ppc64le_debian12
//python3:python3_root_amd64_debian12
//python3:python3_nonroot_amd64_debian12
//cc:cc_nonroot_s390x_debian12
//cc:debug_root_s390x_debian12
//base:base_nossl_root_ppc64le_debian12
//cc:cc_root_arm64_debian12
//cc:cc_nonroot_arm_debian12
//cc:cc_root_ppc64le_debian12
//python3:debug_nonroot_amd64_debian12
//python3:debug_root_arm64_debian12
//python3:debug_nonroot_arm64_debian12
//cc:debug_root_ppc64le_debian12
//nodejs:nodejs18_debug_nonroot_amd64_debian12
//cc:debug_nonroot_arm64_debian12
//python3:python3_nonroot_arm64_debian12
//python3:debug_root_amd64_debian12
//nodejs:nodejs18_root_amd64_debian12
//nodejs:nodejs20_nonroot_amd64_debian12
//cc:cc_root_arm_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//cc:debug_nonroot_s390x_debian12
//nodejs:nodejs18_nonroot_amd64_debian12
//nodejs:nodejs20_debug_root_amd64_debian12
//nodejs:nodejs20_debug_nonroot_amd64_debian12
//nodejs:nodejs22_root_arm64_debian12
//python3:python3_root_arm64_debian12
//nodejs:nodejs18_debug_root_arm64_debian12
//nodejs:nodejs18_nonroot_arm_debian12
//nodejs:nodejs20_nonroot_arm64_debian12
//nodejs:nodejs18_nonroot_arm64_debian12
//nodejs:nodejs18_debug_root_amd64_debian12
//nodejs:nodejs18_debug_root_arm_debian12
//nodejs:nodejs20_root_arm_debian12
//nodejs:nodejs20_root_amd64_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs18_root_arm_debian12
//nodejs:nodejs18_debug_nonroot_arm_debian12
//nodejs:nodejs20_debug_root_arm_debian12
//nodejs:nodejs20_nonroot_arm_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs18_root_s390x_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs18_debug_root_s390x_debian12
//nodejs:nodejs20_debug_nonroot_arm_debian12
//nodejs:nodejs18_debug_nonroot_arm64_debian12
//nodejs:nodejs20_debug_nonroot_arm64_debian12
//nodejs:nodejs20_nonroot_s390x_debian12
//nodejs:nodejs18_debug_nonroot_s390x_debian12
//nodejs:nodejs18_root_arm64_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs20_debug_nonroot_s390x_debian12
//nodejs:nodejs22_nonroot_s390x_debian12
//nodejs:nodejs18_debug_root_ppc64le_debian12
//nodejs:nodejs20_root_s390x_debian12
//nodejs:nodejs20_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs18_root_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs20_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_root_arm64_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs18_nonroot_s390x_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs18_debug_nonroot_ppc64le_debian12
//java:java_base_debug_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//java:java_base_nonroot_arm64_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//java:java_base_nonroot_s390x_debian12
//java:java_base_debug_nonroot_arm64_debian12
//java:java_base_nonroot_amd64_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//java:java_base_root_amd64_debian12
//nodejs:nodejs22_root_s390x_debian12
//java:java_base_root_ppc64le_debian12
//java:java_base_debug_root_ppc64le_debian12
//nodejs:nodejs18_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//java:java17_debug_root_amd64_debian12
//java:java_base_root_arm64_debian12
//java:java_base_debug_root_s390x_debian12
//java:java_base_debug_nonroot_amd64_debian12
//java:java17_root_amd64_debian12
//nodejs:nodejs20_root_ppc64le_debian12
//java:java17_root_arm64_debian12
//java:java_base_root_s390x_debian12
//java:java_base_nonroot_ppc64le_debian12
//java:java17_root_s390x_debian12
//java:java17_root_ppc64le_debian12
//java:java_base_debug_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//java:java_base_debug_nonroot_s390x_debian12
//java:java17_nonroot_amd64_debian12
//java:java17_debug_root_arm64_debian12
//java:java17_debug_nonroot_ppc64le_debian12
//java:java_base_debug_nonroot_ppc64le_debian12
//java:java17_debug_nonroot_amd64_debian12
//java:java17_nonroot_s390x_debian12
//java:java21_nonroot_amd64_debian12
//java:java21_nonroot_arm64_debian12
//java:java21_debug_root_amd64_debian12
//java:java21_nonroot_ppc64le_debian12
//java:java17_nonroot_ppc64le_debian12
//java:java21_debug_nonroot_amd64_debian12
//java:java17_debug_root_s390x_debian12
//java:java21_debug_nonroot_ppc64le_debian12
//java:java21_debug_nonroot_arm64_debian12
//java:java17_debug_nonroot_s390x_debian12
//java:java17_debug_nonroot_arm64_debian12
//java:java21_root_arm64_debian12
//java:java21_root_amd64_debian12
//nodejs:nodejs20_debug_root_s390x_debian12
//java:java17_nonroot_arm64_debian12
//java:java21_root_ppc64le_debian12
//java:java21_debug_root_arm64_debian12
//java:java21_debug_root_ppc64le_debian12
//java:java17_debug_root_ppc64le_debian12

You can check the details in the report here

Aug 09 '24 20:08 github-actions[bot]

@loosebazooka this is ready now.

Aug 12 '24 21:08 thesayyn

cc @alexeagle as he promised to review.

Aug 12 '24 21:08 thesayyn

oh shoot, I merged something in that probs needs a rebase+fix

Aug 13 '24 13:08 loosebazooka

You are receiving this because you are subscribed to this thread.

🙊

Aug 13 '24 14:08 omBratteng

@thesayyn needs a rebase?

Aug 21 '24 14:08 loosebazooka

There are some assumptions in this implementation that make it hard to import this in a downstream module. Will that be supported later?

Sep 02 '24 07:09 mortenmj

There are some assumptions in this implementation that make it hard to import this in a downstream module. Will that be supported later?

I think fundamentally we dont want anyone importing distroless as a downstream module. If you wish to build distroless style images -- rules_distroless is what you need? What exactly is your usecase? Are there pieces in here that need to move into rules_distroless?

Sep 04 '24 14:09 loosebazooka

@thesayyn needs a rebase?

finally got around to rebase. it should be ready now. i can't confirm scripts/update_java_archives.sh works because it fails on a darwin bash...

Sep 06 '24 20:09 thesayyn

I can update the script for Java later

Sep 06 '24 21:09 loosebazooka

looks like the image diffs (non-java) are mostly just related to: https://github.com/GoogleContainerTools/rules_distroless/pull/71

Sep 10 '24 18:09 loosebazooka

java versions need to be sync'd, there was an update here: https://github.com/GoogleContainerTools/distroless/pull/1649

Sep 10 '24 18:09 loosebazooka