distroless icon indicating copy to clipboard operation
distroless copied to clipboard

Standardise naming of nodejs images

Open omBratteng opened this issue 3 years ago • 9 comments

To not fill the PR with non-related discussion, re: https://github.com/GoogleContainerTools/distroless/pull/1083#issuecomment-1184551777, I open this issue as a tracker to discuss standardising nodejs images.

I think it might be time to standardize the naming of nodejs images to be similar to the others.

nodejs<version>-debian<version>:{root, nonroot, debug, debug-nonroot}

We can leave the old naming as legacy for now and deprecate those in ~6 months ?

omBratteng avatar Jul 14 '22 15:07 omBratteng

Examples

  • nodejs18-debian11:latest
  • nodejs16-debian11:debug-nonroot

omBratteng avatar Jul 14 '22 15:07 omBratteng

Would it be optional to drop the -debian<version> suffix, so it would always mean the latest distro version? Like nodejs18:latest would mean nodejs18-debian11:latest.

omBratteng avatar Jul 14 '22 15:07 omBratteng

Would it be optional to drop the -debian suffix, so it would always mean the latest distro version? Like nodejs18:latest would mean nodejs18-debian11:latest.

Yes definitely, I think I forgot about those in my comment

loosebazooka avatar Jul 14 '22 15:07 loosebazooka

In your initial comment, you wrote root. Would that be latest? Or do both? latest and root tag.

omBratteng avatar Jul 14 '22 15:07 omBratteng

right right, another slip. latest is correct.

loosebazooka avatar Jul 14 '22 15:07 loosebazooka

so

nodejs<version>-debian<version>:{latest, nonroot, debug, debug-nonroot}

loosebazooka avatar Jul 14 '22 15:07 loosebazooka

Awesome. I'll take a look at it.

omBratteng avatar Jul 14 '22 15:07 omBratteng

I've opened a draft PR #1086. What's the reason that node14 isn't built with multi-arch? There are arm64 versions of it.

omBratteng avatar Jul 19 '22 22:07 omBratteng

Probably just history. Change to what you think makes sense

loosebazooka avatar Jul 19 '22 22:07 loosebazooka