distroless Add `nonroot` to nodejs images

I came across #892, and thought I'd give it a go to add nonroot images for node

Closes #892

Jul 14 '22 07:07 omBratteng

So many places to add root/nonroot. I think I got them all 🤞🏻

Jul 14 '22 08:07 omBratteng

Yay, all tests went through 🎉

Jul 14 '22 13:07 omBratteng

I think it might be time to standardize the naming of nodejs images to be similar to the others.

nodejs<version>-debian<version>:{root, nonroot, debug, debug-nonroot}

We can leave the old naming as legacy for now and deprecate those in ~6 months ?

Jul 14 '22 14:07 loosebazooka

I see no issue with that. I can do that in another PR.

How about deprecate the old naming 2023-04-30, that matches with the EOL of node 14, so we can drop the non-manifested builds too.

Jul 14 '22 15:07 omBratteng

Yeah, any deprecation timeline is fine, I just want to do it before this root/nonroot stuff goes in.

Jul 14 '22 15:07 loosebazooka

Depends on #1086

Oct 14 '22 13:10 omBratteng

Does this need a rebase or something?

Nov 01 '22 13:11 loosebazooka

I did a rebase, but I think I did something wrong during it. I'll see what's broken and get the tests fixed.

Nov 01 '22 13:11 omBratteng

There, that should fix it 🤞🏻 I had forgotten to add the root in name of the legacy formats

Nov 02 '22 15:11 omBratteng

I did not create nonroot variants for the legacy tags, hoping that's fine?

Nov 02 '22 16:11 omBratteng