distroless icon indicating copy to clipboard operation
distroless copied to clipboard

new rules_pkg versions break distroless cacerts_java

Open cristifalcas opened this issue 3 years ago • 4 comments

We are using cacerts_java internally and after upgrading to a newer version of rules_pkg, we saw that cacerts_java targets are broken now with this error:

every rule of type cacerts_java implicitly depends upon the target '@rules_pkg//:build_tar', but this target could not be found because of: no such target '@rules_pkg//:build_tar': target 'build_tar' not declared in package '' (did you mean 'BUILD'?) defined by

I believe it fails because of this: https://github.com/bazelbuild/rules_pkg/blob/main/CHANGELOG.md#internal-changes-1

It works with older versions: <= 0.4.0

cristifalcas avatar Apr 18 '22 19:04 cristifalcas

Hrmm, yeah those are made private. Don't think we are going to make this upgrade yet, but we are open to accepting PRs to fix this.

loosebazooka avatar May 05 '22 13:05 loosebazooka

we are open to accepting PRs to fix this

What be a proper fix? Maybe there is already a workaround for that, without providing a fix?

boxdot avatar Jun 07 '22 08:06 boxdot

I mean you could just copy those helpers over into here.

loosebazooka avatar Jun 07 '22 13:06 loosebazooka

I opened https://github.com/GoogleContainerTools/distroless/pull/1065 for this

cristifalcas avatar Jun 16 '22 18:06 cristifalcas