vertex-ai-samples icon indicating copy to clipboard operation
vertex-ai-samples copied to clipboard

Add bqml-vertexai-model-registry notebook

Open soheilazangeneh opened this issue 2 years ago • 2 comments

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

  • [x] Use the notebook template as a starting point.
  • [x] Follow the style and grammar rules outlined in the above notebook template.
  • [x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • [ ] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • [ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • [x] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • [x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

soheilazangeneh avatar Aug 09 '22 15:08 soheilazangeneh

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Instead of a bigquery-ml folder, can you put it in the model registry folder? This repo is for demoing Vertex AI so it should highlight the Vertex AI product.

For BQ notebooks, they have their own repo: https://github.com/GoogleCloudPlatform/bigquery-notebooks

ivanmkc avatar Aug 09 '22 20:08 ivanmkc

Instead of a bigquery-ml folder, can you put it in the model registry folder? This repo is for demoing Vertex AI so it should highlight the Vertex AI product.

For BQ notebooks, they have their own repo: https://github.com/GoogleCloudPlatform/bigquery-notebooks

Done.

soheilazangeneh avatar Aug 14 '22 17:08 soheilazangeneh