vertex-ai-samples icon indicating copy to clipboard operation
vertex-ai-samples copied to clipboard

feat: Add notebook for TabNet on Vertex Pipelines

Open sakagarwal opened this issue 3 years ago • 3 comments

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

  • [x] Use the notebook template as a starting point.
  • [x] Follow the style and grammar rules outlined in the above notebook template.
  • [x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • [ ] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • [ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • [x] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • [x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

If you are opening a PR for Community Notebooks under the notebooks/community folder:

  • [ ] This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
  • [ ] Passes all the required formatting and linting checks. You can locally test with these instructions.

If you are opening a PR for Community Content under the community-content folder:

  • [ ] Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
  • [ ] The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
  • [ ] Passes all the required formatting and linting checks. You can locally test with these instructions.

sakagarwal avatar Jul 16 '22 00:07 sakagarwal

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ivanmkc could you help take a look at this as well? This is also for structured data. Thanks!

helinwang avatar Jul 16 '22 01:07 helinwang

@reznitskii I cleaned up the text in the notebook by removing the large parameters section, adding links to documentation, and adding more details under the CustomJob/HPT job sections. Could you please help take a look? Any feedback would be helpful. Thanks!

sakagarwal avatar Jul 21 '22 22:07 sakagarwal