vertex-ai-samples icon indicating copy to clipboard operation
vertex-ai-samples copied to clipboard

refactor(egen): template fixes, adds clean up steps

Open UBhavani opened this issue 1 year ago • 2 comments

This PR consists of the following updates:

1. Refactors the notebook according to the notebook template (removes boilerplate elements, renames REGION with LOCATION and re-structures the sections).
2. Removes the usage of future tense(will) according to the guidelines.
3. Adds model deletion steps in clean up section.

REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • [x] Use the notebook template as a starting point.
  • [x] Follow the style and grammar rules outlined in the above notebook template.
  • [x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • [x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • [ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • [ ] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • [x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

UBhavani avatar Jul 02 '24 06:07 UBhavani

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

/gcbrun

gericdong avatar Jul 02 '24 12:07 gericdong

/gcbrun

gericdong avatar Jul 03 '24 13:07 gericdong

/gcbrun

gericdong avatar Jul 04 '24 18:07 gericdong

/gcbrun

katiemn avatar Jul 09 '24 02:07 katiemn

Closing it, due to the conflict with duplicate files.

UBhavani avatar Jul 18 '24 13:07 UBhavani