vertex-ai-samples icon indicating copy to clipboard operation
vertex-ai-samples copied to clipboard

Update deploy links and labels to Vertex AI Workbench

Open prodonjs opened this issue 3 years ago • 7 comments

Cloud AI Platform Notebooks is now branded as Vertex AI Workbench (https://cloud.google.com/vertex-ai/docs/workbench/introduction).

This updates all links to the proper format and branding.

prodonjs avatar Feb 02 '22 22:02 prodonjs

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@GoogleCloudPlatform/vertex-ai-samples-owners

I'm trying to update the deployment links that are currently outdated for the Vertex AI Workbench (formerly Notebooks) product. Unfortunately it looks like I'm triggering a bunch of lint errors that were previously present in the submitted code that don't appear to be able to be fixed manually.

I can certainly take a stab at addressing them but there are quite a few files here and I was wondering if there was a manual override possible in this case since my change is a strict find/replace. Thanks!

prodonjs avatar Feb 03 '22 16:02 prodonjs

/gcbrun

kweinmeister avatar Feb 11 '22 15:02 kweinmeister

This will be a tough PR to fix. Partially as it's a bit old and will require some rebasing.

I recommend:

  1. Removing any changes to non-notebook files like the changes to the linter infra.
  2. Updating local main
  3. Rebasing on local main
  4. Push
  5. See what notebooks have conflicts and remove them from this PR for now.

ivanmkc avatar Feb 28 '22 16:02 ivanmkc

@prodonjs Do you want to still proceed with this PR, or should we close it?

kweinmeister avatar Jun 18 '22 23:06 kweinmeister

@kweinmeister - I would like to try to get this in purely to find/replace the broken links.

prodonjs avatar Jun 21 '22 16:06 prodonjs

Google Cloud Build / vertex-ai-notebook-execution-test (python-docs-samples-tests) failed 6 days ago in 7h 24m 23s

andrewferlitsch avatar Aug 03 '22 19:08 andrewferlitsch

We will have to revisit this. It touches too many notebooks that there will inevitably be many conflicts.

ivanmkc avatar Nov 11 '22 23:11 ivanmkc