feat: Add Access config

[shinji62]

Adding Access config , IPV6 : Access configurations, i.e. IPs via which the VM instance can be accessed via the Internet.

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[shinji62]

@apeabody I addeed the change you wanted

[apeabody]

/gcbrun

[apeabody]

Looks like the CI TEST is seeing a permadiff:

TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: Terraform will perform the following actions:
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: 
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:   # module.tfc_agent_gke.module.tfc_agent_cluster.google_container_node_pool.pools["tfc-agent-pool"] will be updated in-place
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:   ~ resource "google_container_node_pool" "pools" {
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:         id                          = "projects/ci-tf-cloud-agents-a5c7/locations/us-central1-a/clusters/tfc-agent-k8s-dey7/nodePools/tfc-agent-pool"
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:         name                        = "tfc-agent-pool"
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:         # (11 unchanged attributes hidden)
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: 
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:       ~ node_config {
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:             tags                        = [
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:                 "gke-tfc-agent-k8s-dey7",
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:                 "gke-tfc-agent-k8s-dey7-tfc-agent-pool",
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:             ]
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:             # (20 unchanged attributes hidden)
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: 
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:           - kubelet_config {
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:               - cpu_cfs_quota                          = false -> null
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:               - insecure_kubelet_readonly_port_enabled = "FALSE" -> null
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:               - pod_pids_limit                         = 0 -> null
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:                 # (2 unchanged attributes hidden)
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:             }
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: 
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:             # (2 unchanged blocks hidden)
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:         }
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: 
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:         # (5 unchanged blocks hidden)
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185:     }
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: 
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: Plan: 0 to add, 1 to change, 0 to destroy.
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: 
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: ─────────────────────────────────────────────────────────────────────────────
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: 
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: Note: You didn't use the -out option to save this plan, so Terraform can't
TestTfcAgentGkeSimple 2024-09-11T03:51:17Z command.go:185: guarantee to take exactly these actions if you run "terraform apply" now.
    terraform.go:537: 
        	Error Trace:	/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:537
        	            				/workspace/test/integration/tfc-agent-gke-simple/tfc_agent_gke_simple_test.go:33
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:638
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
        	Error:      	Should not be: 2
        	Test:       	TestTfcAgentGkeSimple
        	Messages:   	plan after apply should have no diff

[shinji62]

@apeabody I did not change or touch this part, my guess would be that a different google provider version is use, maybe because of the bump of some Google module in my change.

But I don't think I can fix that myself.

[apeabody]

@apeabody I did not change or touch this part, my guess would be that a different google provider version is use, maybe because of the bump of some Google module in my change.

But I don't think I can fix that myself.

Thanks @shinji62! - Very likely. I'll review this PR once the repo CI is updated.

[shinji62]

@apeabody Please let me know when you fix / find the issue :)

[github-actions[bot]]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days