terraform-google-cloud-run icon indicating copy to clipboard operation
terraform-google-cloud-run copied to clipboard

fix(job-exec): support all volume options in job-exec module

Open PFacheris opened this issue 10 months ago • 5 comments

Fixes #286. Not sure why these options aren't available in the job-exec module so just copied them over from the v2 module. Tested with a GCS volume and works perfectly.

PFacheris avatar Jan 30 '25 22:01 PFacheris

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 30 '25 22:01 google-cla[bot]

@PFacheris : Are you still interested/available to move this forward? Are you OK with sb else picking it up?

pataquets avatar May 27 '25 14:05 pataquets

@pataquets I'm fine with someone else picking it up though as far as I'm aware there's not really anything to be done at the moment. Just waiting on someone from the Google side to take a look and provide any feedback.

cc: @anamer @ayushmjain @prabhu34 or @q2w (since I see you listed as the code owners)

PFacheris avatar May 27 '25 18:05 PFacheris

@PFacheris Could you run command for generating the documentation? https://codelabs.developers.google.com/cft-onboarding/#8

q2w avatar Jul 15 '25 18:07 q2w

@PFacheris Could you run command for generating the documentation? https://codelabs.developers.google.com/cft-onboarding/#8

Apologies for the delay on this, done now! Let me know if there's anything else.

PFacheris avatar Jul 29 '25 08:07 PFacheris