terraform-google-cloud-run
terraform-google-cloud-run copied to clipboard
Env vars as a map
Support providing env vars as map(string) of k/v rather than list of objects. @prabhu34 any concerns with this for a future breaking change?
Hi @bharathkkb,
Environment variable can be of any type as in the below screenshot. Here map(string) or list(objects) cannot be the right types, as the values can be string, list or map.
If we are restricting to only string then it is good to go and use map(string) instead of list(objects). It wont break the existing application as the key name is considered as the indexed.
To include other types, I tried using any type of variable, but I am skeptical about the encoding being done for string env variable as well.
Thanks @prabhu34, where is the screenshot from? IIUC the provider restricts us to only string type? https://github.com/hashicorp/terraform-provider-google/blob/c3f2efe0b182293c781e8630e46bc86fa6433112/google/services/cloudrun/resource_cloud_run_service.go#L1132
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days