terraform-dynamic-javascript-webapp icon indicating copy to clipboard operation
terraform-dynamic-javascript-webapp copied to clipboard

fix: Bring back DefaultVerify

Open NimJay opened this issue 11 months ago • 1 comments

Description

Please see this GitHub pull-request for a different JSS (Jump Start Solution).

Checklist

  • [x] Please merge this PR for me once it is approved.

NimJay avatar Mar 22 '24 19:03 NimJay

int tests are failing because TF wants to delete the default firestore.

This could be fixed (potentially) with a deletion_policy or similar attribute.

Potentially could also be fixed with the changes in #124. Could this PR be combined with that one to see if it works together?

glasnt avatar Apr 17 '24 04:04 glasnt

The 2nd terraform apply was trying to destroy the Firestore database (named default). This is because local.has_default_firestore_database renders as true during the 2nd terraform apply. So, in addition to local.has_default_firestore_database, we also need to check if this Terraform module was the one that created the the Firestore database.

NimJay avatar May 06 '24 13:05 NimJay

Looks like I ran into a Terraform issue:

Terraform crashed! This is always indicative of a bug within Terraform.
...
panic: no expansion has been registered for module.dynamic_web_app.google_firestore_database.database

I need to know the Terraform verison. I just added a step to the Cloud Build trigger and opened https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/issues/2321:

- id: log-terraform-version
  name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
  args: ['/bin/bash', '-c', 'terraform version']

NimJay avatar May 06 '24 14:05 NimJay