stackdriver-errors-js icon indicating copy to clipboard operation
stackdriver-errors-js copied to clipboard

Fails to report an Angular `HttpErrorResponse`

Open beck opened this issue 5 years ago • 0 comments

As is

  • Using Angular
  • Make a service request, throw a 500HttpErrorResponse
  • Report this error with StackdriverErrorHandler
  • Get a 400 from the service, error never reported

These errors do not have a stack trace, so the payload sent to the clouderrorreporting api was:

{
  "serviceContext": { "service": "my-service" },
  "context": {
    "httpRequest": {
      "userAgent": "Mozilla/5.0 ...",
      "url": "http://localhost:3000/app/123"
    }
  },
  "message": "Error extracting stack trace: Error: Cannot parse given Error object\n[object Object]\n    (::)"
}

The service then responded with:

400 - ReportedErrorEvent.context must contain a location unless message contain an exception or stacktrace.

Expected

Errors without a stack would be serialized in a way to maintain as much information as possible.

It is surprising to send "Error extracting stack trace" instead of a message representing the error trying to be reported.

One quick fix I tried to implement was to JSON.stringify errors before reporting, those were rejected by the service as "too long".

Overall, would love if the client would do everything possible to ensure the error gets reported.

beck avatar Sep 24 '20 14:09 beck