runtimes-common icon indicating copy to clipboard operation
runtimes-common copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Inherit env vars in sudo uses.

Open msuozzo opened this issue 2 years ago • 5 comments

msuozzo avatar Sep 01 '22 16:09 msuozzo

Hi @msuozzo, thanks for proposing this change. I need a bit time and research to understand the impact of this change. If you could help me understand the following questions, I would be able to approve it much faster:

  • Why do we need to make this change? Is the previous version (w/o -E) causing any issues?
  • Why is it safe to do so? I'm asking because this is a flag to sudo.

jinglundong avatar Sep 02 '22 01:09 jinglundong

Discussed internally. This looks good to me.

jinglundong avatar Sep 02 '22 01:09 jinglundong

do you know what the CI issue could be here? doesn't seem to be resolving

msuozzo avatar Sep 02 '22 17:09 msuozzo

Seems like there's no links to check the kokoro status. I'm also seeing that kokoro Expected — Waiting for status to be reported message for over 12 hours.

jinglundong avatar Sep 02 '22 19:09 jinglundong

To move forward, you may look for the corresponding kokoro workflow to this repo. (I'm working on a high priority bug, so couldn't dive too deep into this today. )

jinglundong avatar Sep 02 '22 19:09 jinglundong