python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

chore(deps): update dependency google-cloud-logging to v3.2.2

Open renovate-bot opened this issue 2 years ago • 2 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
google-cloud-logging ==3.1.2 -> ==3.2.5 age adoption passing confidence
google-cloud-logging ==2.7.2 -> ==3.2.5 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

renovate-bot avatar Jul 12 '22 14:07 renovate-bot

It looks like this is the offending PR. (It adds an extra logging statement, which breaks our tests.)

@daniel-sanche which option is better here?

  1. Update these samples to pass with this change
  2. Add a flag to the library to disable this behavior

I have a slight preference for the second option, but I definitely don't have enough context to know for sure.

ace-n avatar Jul 14 '22 19:07 ace-n

@daniel-sanche friendly ping!

dandhlee avatar Sep 30 '22 16:09 dandhlee

Sorry, must have missed this!

The easiest solution for testing is probably to use the existing internal flag to disable instrumentation for the tests here: google.cloud.logging_v2._instrumentation_emitted = True. I think changing the tests is also acceptable if that ends up being easier though.

Let me know if you want me to take on the changes

daniel-sanche avatar Nov 14 '22 18:11 daniel-sanche

Thanks Daniel! I'll leave this open for now, and open a separate issue and assign it to you @ace-n but feel free to assign to someone else who has bandwidth if you can't work on it soon.

dandhlee avatar Nov 15 '22 08:11 dandhlee

For anyone else who needs higher version of cloud logging, please make the updates separately.

dandhlee avatar Nov 15 '22 08:11 dandhlee

Rolled back logging version for Cloud Functions sample, will figure out problem and fix in a future PR.

engelke avatar Nov 16 '22 23:11 engelke

Why would this only affect the Cloud Functions v2 test? And why only when run by Kokoro? The tests pass locally.

engelke avatar Nov 17 '22 00:11 engelke