python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

add samples for using a regional endpoint with SCC v2 API

Open onagbonoga opened this issue 1 year ago • 6 comments

Description

The SCC API can be accessed via Regional Endpoints to meet customer data residency requirements. This sample shows how to override the endpoint for an API client. See https://cloud.google.com/security-command-center/docs/data-residency-support.md#regional-urls for more information on data residency

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

onagbonoga avatar Oct 30 '24 21:10 onagbonoga

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Oct 30 '24 22:10 snippet-bot[bot]

@onagbonoga it feels like this is pretty duplicative of https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/securitycenter/snippets_v2/snippets_findings_v2.py bar the sending options which seems like it could be an addition to the existing snippet. Any particular reason to need both?

iennae avatar Nov 21 '24 07:11 iennae

@onagbonoga it feels like this is pretty duplicative of https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/securitycenter/snippets_v2/snippets_findings_v2.py bar the sending options which seems like it could be an addition to the existing snippet. Any particular reason to need both?

Thank you. I have added the samples to snippets_findings_v2.py

onagbonoga avatar Dec 04 '24 17:12 onagbonoga

Hi @onagbonoga. Since this PR was created, we're introduced Python 3.13 testing. Please rebase your PR so these tests can be run.

glasnt avatar Mar 05 '25 04:03 glasnt

It looks like this PR was rebased incorrectly, given the amount of people tagged on this change when it should (by title) only be a small isolated change.

Since this is a branch on the main repo, it might be related to your main branch not being in sync.

I'm going to force rebase, which should help.

glasnt avatar Aug 08 '25 02:08 glasnt

I've rebased this change, but the added test is failing. Please address ✨

glasnt avatar Aug 08 '25 02:08 glasnt