python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

Resolving issue with regex for composer environments

Open killkelleyr opened this issue 1 year ago • 4 comments

Description

Fixes #12580

Checklist

killkelleyr avatar Sep 11 '24 14:09 killkelleyr

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 11 '24 14:09 google-cla[bot]

Looks like this will require additional changes as it currently produces the following errors since minor and patch are not set.

2024-09-12 14:15:47,029 - Image version: composer-3-airflow-2.9.1-build.6
Traceback (most recent call last):
  File "/home/rkillkelley/composer_dags.py", line 229, in <module>
    main(
  File "/home/rkillkelley/composer_dags.py", line 173, in main
    airflow_version = (int(versions[3]), int(versions[4]), int(versions[5]))
IndexError: tuple index out of range

I will update to ensure minor and patch default to 0

killkelleyr avatar Sep 12 '24 18:09 killkelleyr

@killkelleyr thanks for contributing this fix. @leahecole can you take a look?

iennae avatar Sep 13 '24 02:09 iennae

This PR requires a rebase due to testing changes in this repo. If this PR is no longer needed, please close ✨

glasnt avatar Aug 08 '25 02:08 glasnt