python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

feat(scc): add samples for SCC v2 findings

Open thokalavinod opened this issue 1 year ago • 1 comments

Related to b/339692150 https://cloud.google.com/security-command-center/docs/reference/rest/v2/organizations.sources.locations.findings

Fixes #<ISSUE-NUMBER>

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

thokalavinod avatar Jul 03 '24 01:07 thokalavinod

Here is the summary of changes.

You are about to add 8 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Jul 03 '24 01:07 snippet-bot[bot]

@thokalavinod

The samples differ from the Java ones here: https://github.com/GoogleCloudPlatform/java-docs-samples/tree/main/security-command-center/snippets/src/main/java/vtwo/findings

Kindly reconcile python samples to match with Java.

Sita04 avatar Jul 05 '24 15:07 Sita04

Hi @m-strzelczyk, Can you help me to run the PR for checking any errors in Kokoro. Thankyou

thokalavinod avatar Jul 16 '24 18:07 thokalavinod

We don't have GCLOUD_ORGANIZATION defined for the tests - what should it be?

@Sita04 how do you set the SCC_PROJECT_ORG_ID in Java? @thokalavinod maybe we should use the same name as in java?

m-strzelczyk avatar Jul 17 '24 11:07 m-strzelczyk

We don't have GCLOUD_ORGANIZATION defined for the tests - what should it be?

@Sita04 how do you set the SCC_PROJECT_ORG_ID in Java? @thokalavinod maybe we should use the same name as in java?

@m-strzelczyk We fetch the values from this secret: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/.kokoro/tests/run_tests.sh#L84 Kindly help import this secret into this repo.

And yes, @thokalavinod update the env variable names to the same as in Java.

Sita04 avatar Jul 18 '24 15:07 Sita04

@thokalavinod This PR looks like a duplicate of https://github.com/GoogleCloudPlatform/python-docs-samples/pull/12011 Kindly close this PR.

@RajviM for visbility.

Sita04 avatar Jul 18 '24 17:07 Sita04

To avoid conflicts between PR's, I am closing this PR. I had used all the files in the below PR link. https://github.com/GoogleCloudPlatform/python-docs-samples/pull/12011

thokalavinod avatar Jul 19 '24 04:07 thokalavinod