prometheus-engine icon indicating copy to clipboard operation
prometheus-engine copied to clipboard

build(frontend): make embedded assets the default behavior

Open hsmatulis opened this issue 1 month ago • 2 comments

Inverts the build tag logic to ensure that standard go build commands produce self-contained binaries with embedded assets. The dev workflow allowing for live updates must be explicitly specified now.

hsmatulis avatar Dec 11 '25 07:12 hsmatulis

This could be also verified with test: https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1822

Also if we do this let's ensure https://github.com/GoogleCloudPlatform/prometheus-engine/blob/main/hack/update-ui.sh works, can you double check that?

bwplotka avatar Dec 11 '25 15:12 bwplotka

This could be also verified with test: #1822

Yup! thats awesome, I'll rebase it

Also if we do this let's ensure https://github.com/GoogleCloudPlatform/prometheus-engine/blob/main/hack/update-ui.sh works, can you double check that?

Hmm it looks like that script is already failing at head, and has been since this commi 3 years ago: https://github.com/GoogleCloudPlatform/prometheus-engine/commit/26581ba57bdf750ab2e8cfd8f2c50f3e552e1eb7

Looks like we removed the static/.gitignore dir that touch static/.gitignorein the script expects

hsmatulis avatar Dec 11 '25 23:12 hsmatulis