professional-services icon indicating copy to clipboard operation
professional-services copied to clipboard

Add precommit checks to look for secrets and other stuff

Open boredabdel opened this issue 5 years ago • 3 comments

While reviewing https://github.com/GoogleCloudPlatform/professional-services/pull/543 @jaketf had a great suggestion about using precommit-checks https://pre-commit.com/ to look for secrets (like private SA keys) and maybe even enforce license and stuff like that.

I'm not sure how the repo is configure but will have a look at this.

boredabdel avatar Aug 28 '20 15:08 boredabdel

@boredabdel I have a decent amount of experience w/ pre-commit. This example (PSO internal CSR link) might help get you started. I'd be happy to discuss / help if you need. The biggest challenge is the fact that we have so many assets in the exclusion list.

jaketf avatar Jan 21 '21 18:01 jaketf

We have separate repo for pre-commit hooks. https://github.com/google/pre-commit-tool-hooks is it interesting for you?

mik-laj avatar Jan 21 '21 18:01 mik-laj

@mik-laj very interesting! thank you for pointing this out!

jaketf avatar Jan 21 '21 18:01 jaketf