php-docs-samples icon indicating copy to clipboard operation
php-docs-samples copied to clipboard

Move processFunctionLogs functions into a library

Open ace-n opened this issue 4 years ago • 1 comments

I've noticed several (and counting) of our Cloud Functions samples' DeployTests define a processFunctionLogs function.

Since these functions are largely similar (if not the same) across all these files, we should move this logic to a shared library (e.g. php-tools) or a single location within the repo (maybe the root-level testing directory?).

ace-n avatar Dec 15 '20 03:12 ace-n

I suggest following the existing pattern and putting this inside the CloudFunctionsDeployTrait or creating a new trait to encapsulate utilities for async testing. When the first example was merged, we discussed that being a useful follow-up as part of the 2nd or 3rd usage to make sure we understood the needed logic.

grayside avatar Jan 06 '21 17:01 grayside