opentelemetry-operations-python icon indicating copy to clipboard operation
opentelemetry-operations-python copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Replace use of deprecated class BoundedDict with BoundedAttributes

Open shevisj opened this issue 1 year ago • 7 comments

Replace deprecated BoundedDict with BoundedAttributes and bump minimum version requirement of opentelemetry-api from 1.0 to 1.4 in opentelemetry-exporter-gcp-trace

Fixes https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/issues/226

shevisj avatar Apr 21 '23 19:04 shevisj

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 21 '23 19:04 google-cla[bot]

/gcbrun

aabmass avatar Apr 24 '23 19:04 aabmass

I'm fixing the CI in https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/pull/239

aabmass avatar Apr 24 '23 19:04 aabmass

/gcbrun

aabmass avatar Apr 25 '23 15:04 aabmass

Hmm, unfortunately it looks like the BoundedAttributes class has tighter constraints on allowed attribute value types as compared with BoundedDict. I will work on getting my local dev env configured so that I can play around with it and can get tests to pass locally.

shevisj avatar Apr 25 '23 23:04 shevisj

/gcbrun

aabmass avatar May 01 '23 15:05 aabmass

@shevisj do you have any idea how to fix the issue or could update this PR?

aabmass avatar Jul 17 '23 18:07 aabmass