nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

feat(parametermanager): add global and regional samples for kms_key field

Open vatsal-vora-crestdata opened this issue 8 months ago • 1 comments

Description

Created samples for the KMS key field in the global and regional parameter manager.

Added Sample List:

  1. create_regional_param_with_kms_key
  2. remove_regional_param_kms_key
  3. update_regional_param_kms_key
  4. create_param_with_kms_key
  5. remove_param_kms_key
  6. update_param_kms_key

Checklist

  • [X] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [X] Tests pass: npm test (see Testing)
  • [X] Lint pass: npm run lint (see Style)
  • [X] These samples need a new API enabled in testing projects to pass (let us know which ones) - This requires Parameter manager API to be enabled
  • [X] These samples need a new/updated env vars in testing projects set to pass (let us know which ones) - This requires GCLOUD_LOCATION to be set otherwise it will use us-central1
  • [ ] This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • [X] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [X] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [X] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [X] Please merge this PR for me once it is approved

vatsal-vora-crestdata avatar Apr 02 '25 12:04 vatsal-vora-crestdata

Raised a duplicate of this PR https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/4071 because Vatsal's CLA has expired, which is blocking the merge. Once the new PR is merged, will close the original one.

durgesh-ninave-crest avatar Apr 09 '25 08:04 durgesh-ninave-crest

the new PR has been merged so I'm going to close this one.

iennae avatar Aug 28 '25 17:08 iennae