nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

feat: tpu_queued_resources_startup_script/create_network/time_bound

Open gryczj opened this issue 1 year ago • 7 comments

Description

Fixes #<ISSUE-NUMBER>

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [x] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [x] Tests pass: npm test (see Testing)
  • [x] Lint pass: npm run lint (see Style)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [x] This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • [x] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [x] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [x] Please merge this PR for me once it is approved

gryczj avatar Oct 23 '24 11:10 gryczj

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Oct 23 '24 11:10 snippet-bot[bot]

Due to high costs of TPU Nodes, it was decided to use mocks in the tests.

gryczj avatar Nov 12 '24 17:11 gryczj

@gemini review

iennae avatar Nov 21 '24 06:11 iennae

Hi @iennae, could you please take a look once again on this PR?

cc: @rsamborski

BigBlackWolf avatar Dec 16 '24 10:12 BigBlackWolf

The users that are currently failing CLA had CLA signed at the time they were committing the changes. Please force-merge the PR.

m-strzelczyk avatar Jan 13 '25 13:01 m-strzelczyk

Can confirm the CLAs were signed per previous checks https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/3907/checks?check_run_id=34201685809

glasnt avatar Mar 05 '25 02:03 glasnt

@m-strzelczyk Can you please re-review? Your previous review appears to not be valid any more.

glasnt avatar Mar 05 '25 02:03 glasnt