nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

fix: snake case instead of pascalCase as it conflicts with types

Open 5war00p opened this issue 1 year ago • 2 comments

Description

Fixes #3611

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [x] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [x] Tests pass: npm test (see Testing)
  • [x] Lint pass: npm run lint (see Style)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [ ] This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [ ] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [x] Please merge this PR for me once it is approved

5war00p avatar Jan 18 '24 06:01 5war00p

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 18 '24 06:01 google-cla[bot]

Please see https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/3611#issuecomment-1932723084.

pattishin avatar Feb 07 '24 19:02 pattishin

Closing out (comment)

pattishin avatar Feb 21 '24 17:02 pattishin