nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

EOS (End of Support) for nodejs16

Open Judge-Paul opened this issue 1 year ago • 3 comments

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

The issue you're having must be related to a file in this repository. We are unable to provide assistance for issues unrelated to samples in this repository.

Please include as much information as possible:

In which file did you encounter the issue?

yaml example for app engine

Did you change the file? If so, how?

Update to use node 18

Describe the issue

Node 16 is about to reach its End of support by the node community and app engine is throwing an error that I won't be allowed to use node 16 by that time so I think the docs should be updated to use node 18

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

Judge-Paul avatar Jan 11 '24 13:01 Judge-Paul

References to Node v16 exist in many other files. See https://github.com/GoogleCloudPlatform/nodejs-docs-samples/commit/12253139b0abfaa742f15a1a0b44fe67242f955d

matharden avatar Jan 17 '24 15:01 matharden

References to Node v16 exist in many other files. See 1225313

Oh okay, but are you working on updating it across all files?

Judge-Paul avatar Jan 17 '24 15:01 Judge-Paul

@Judge-Paul Thanks so much for filing this issue; We'll sort out getting this updated to the version needed (20 at this time for App Engine).

iennae avatar Jan 26 '24 20:01 iennae

Thanks again, had to resolve some other issues but this is now resolved for this sample. There are other app engine samples that will need to get updated but that is tracked in a separate issue.

iennae avatar Apr 16 '24 22:04 iennae