nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

fix(wip): update cloud run markdown sample from cjs to esm 🚧

Open pattishin opened this issue 1 year ago • 2 comments

Description

Fixes b-253601199

Ref: https://github.com/sindresorhus/got/issues/1257

Checklist

  • [x] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [ ] Tests pass: npm test (see Testing)
  • [x] Lint pass: npm run lint (see Style)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [ ] This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [ ] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [x] Please merge this PR for me once it is approved

pattishin avatar Dec 15 '23 04:12 pattishin

Checking out failed kokoro tests 👍🏼

pattishin avatar Dec 15 '23 05:12 pattishin

Update: Requires node 20 image to pass CI. More information added to task.

pattishin avatar Dec 21 '23 01:12 pattishin