nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

Migrate instructions to use Artifact Registry

Open steren opened this issue 1 year ago • 3 comments

On this page, users are invited to use gcr.io.

These instructions should be updated to use Artifact Registry

steren avatar Jun 26 '23 16:06 steren

@jama22 , that Cloud Run page mentions both Artifact Registry and also GCR but in the context of buildpacks. Will buildpacks move to AR or do we need to continue using the GCR URL locations?

RichieEscarez avatar Jun 29 '23 17:06 RichieEscarez

/assign @jama22

The GCR reference is here in the page: https://cloud.google.com/run/docs/deploying-source-code#limits

"Deploying from source with Google Cloud's buildpacks always uses gcr.io/buildpacks/builder:latest."

If buildpacks are to remain in GCR, then this issue can be closed because the page otherwise uses Artifact Registry.

RichieEscarez avatar Aug 04 '23 17:08 RichieEscarez

we have some plans to get an AR reigstry address for that builder, so we can leave this issue open and I'll make a PR to update when we have that address available

jama22 avatar Aug 04 '23 18:08 jama22

@jama22 as of May 15, 2024 Artifact Registry will host images for the gcr.io domain by default. When I look up gcr.io/buildpacks/builder:latest it still looks like it's using Container Registry. Do we know the plan/impact for this?

iennae avatar Apr 17 '24 04:04 iennae

I'm going to go ahead and close this issue. the gcr domain redirection will work once it's set up. Currently, it does still look like Container Registry is still in use, but based on the way the feature works, once migrated it will work seamlessly. There isn't anything that needs to be done from the sample side of things at this time.

iennae avatar Jun 28 '24 02:06 iennae