nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

Running GitHub Workflows duplicate events: push and pull_request

Open grayside opened this issue 3 years ago • 0 comments

The GitHub Workflow template runs for each set of samples on push and pull_request.

Based on my reading of the syntax documentation, pull_request is necessary for forks.

It looks like folks contributing from a branch in the repository would trigger duplicate tests. Looking at some data, I don't see signs of duplicate work but documented points like https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-multiple-events indicate that there should be.

Action Items from this issue should be one of:

  • Removing push as an event trigger from each config and the template
  • Adding an in-line comment to each config and the template explaining why we use both

@sofisl could you provide some insight into why we have both triggering events in the config?

grayside avatar Nov 29 '22 17:11 grayside