nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

samples(healthcare v1): initial consent store CRUD method samples with new subdirectory

Open noerog opened this issue 2 years ago • 5 comments

New directory and initial samples for Healthcare API consent modality. Part of b/224797364.

noerog avatar Mar 25 '22 04:03 noerog

Here is the summary of possible violations 😱

There is a possible violation for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 43 region tags.
You are about to delete 4 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Mar 25 '22 04:03 snippet-bot[bot]

@GoogleCloudPlatform/nodejs-samples-reviewers Ping

noerog avatar Mar 31 '22 17:03 noerog

Looks like tests are not running for this directory. Could I trouble you to set up a workflow, just like these here? https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/.github/workflows. Then we can make sure that tests are passing for this new directory.

sofisl avatar Apr 01 '22 00:04 sofisl

Looks like tests are not running for this directory. Could I trouble you to set up a workflow, just like these here? https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/.github/workflows. Then we can make sure that tests are passing for this new directory.

Done.

noerog avatar Apr 01 '22 21:04 noerog

It looks like there are some permissions errors. We had the same issue when adding these samples with a new directory in python-docs-samples. Would it be possible to verify that the service account used to run tests has the correct permissions?

noerog avatar Apr 01 '22 21:04 noerog