nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

Adding Readme for eventarc samples

Open gcp-grauj opened this issue 3 years ago • 3 comments

There is no Readme documents for all the samples under the eventarc/ folder.

Some of these samples are used on the official Eventarc docs, but some are not (for example, the generic sample it's not documented).

Would it be possible to add a short readme for each of these samples, or one for all of them, explaining the usage and goal for each of the samples on that folder [1]?

Thanks in advance!

[1] https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/eventarc

gcp-grauj avatar Mar 21 '22 10:03 gcp-grauj

@grant It looks like you authored these awhile back - can you take a look?

chingor13 avatar Mar 21 '22 18:03 chingor13

Hi @gcp-grauj, I hope these samples are useful! Yes, not all of them are used in the docs.

The generic sample can be used with any eventarc trigger. Here is some example setup for a related sample: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/eventarc/pubsub

grant avatar Mar 21 '22 19:03 grant

@chingor13 Thanks. I no longer work on this, however I added a reply.

In terms of owners, I'd contact the serverless DPE folks and add them to https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CODEOWNERS for further work.

grant avatar Mar 21 '22 19:03 grant

Closing out as request is ~2 years old.

pattishin avatar Feb 27 '24 20:02 pattishin