microservices-demo icon indicating copy to clipboard operation
microservices-demo copied to clipboard

Use `pino` instead of `console.log`

Open NimJay opened this issue 3 years ago • 1 comments

Describe request or inquiry

What purpose/environment will this feature serve?

  • See pull-request 66 — where the use of pino was introduced — for reasoning.
  • Basically, we want our logs to be formatted as JSON — for Stackdriver. See #47.

NimJay avatar Dec 29 '21 16:12 NimJay

Update (2022 July)

Just adding an update to cool this issue down (i.e., remove it from our team's out-of-SLO list). No progress updates and this issue is still very low priority. I wonder if this ticket will be addressed (indirectly) by https://github.com/GoogleCloudPlatform/microservices-demo/issues/422 (i.e., will switching to OpenTelemetry render this issue irrelevant?).

NimJay avatar Jul 14 '22 15:07 NimJay

Hi I want to contribute to this issue please assign me this issue

aarushisoni avatar Dec 07 '22 11:12 aarushisoni

Hi @aarushisoni, Thanks again for your interest. This is definitely a good first issue to work on. :) I've assigned it to you.

NimJay avatar Dec 07 '22 16:12 NimJay

Hi @NimJay since no progress in this issue can I get assigned to this issue. I'll be happy to work on this. @aarushisoni are you still working on this?

TonyBhargav avatar Jan 22 '23 15:01 TonyBhargav

Hi @NimJay is someone working on this issue? i would like give it a shot c:

andresmc98 avatar Apr 25 '23 23:04 andresmc98

Hi @andresmc98, :)

I don't think anyone was working on this. Correct my if I'm wrong, @TonyBhargav. :) I just assigned it to you (@andresmc98).

Just a heads-up: please see before starting any work:

Thank you all, for your interest in contributing.

NimJay avatar Apr 26 '23 13:04 NimJay

Thank you, so i'll checks the docs first

andresmc98 avatar Apr 26 '23 18:04 andresmc98

Hi @NimJay, can you assign this one to me? I've already made relevant changes to both index.js and server.js files on my local. I want to confirm the changes with you.

DracFiendMG avatar Nov 12 '23 10:11 DracFiendMG

@NimJay, I just noticed that /src/currencyservice/server.js already has pino implemented, can you confirm?

DracFiendMG avatar Nov 12 '23 16:11 DracFiendMG

@NimJay, I've raised a PR: https://github.com/GoogleCloudPlatform/microservices-demo/pull/2262 Can you look into it and let me know if I'm missing something?

DracFiendMG avatar Nov 13 '23 10:11 DracFiendMG

@NimJay, I've already committed my changes can you look into it

DracFiendMG avatar Nov 17 '23 11:11 DracFiendMG