microservices-demo
microservices-demo copied to clipboard
Use `pino` instead of `console.log`
Describe request or inquiry
- Both JavaScript/Node.js microservices (
paymentservice
andcurrencyservice
) useconsole.log
. - See files:
- Let's use
pino
instead. - We're already using
pino
in other JavaScript files. - This idea originated from 665.
What purpose/environment will this feature serve?
- See pull-request 66 — where the use of
pino
was introduced — for reasoning. - Basically, we want our logs to be formatted as JSON — for Stackdriver. See #47.
Update (2022 July)
Just adding an update to cool this issue down (i.e., remove it from our team's out-of-SLO list). No progress updates and this issue is still very low priority. I wonder if this ticket will be addressed (indirectly) by https://github.com/GoogleCloudPlatform/microservices-demo/issues/422 (i.e., will switching to OpenTelemetry render this issue irrelevant?).
Hi I want to contribute to this issue please assign me this issue
Hi @aarushisoni, Thanks again for your interest. This is definitely a good first issue to work on. :) I've assigned it to you.
Hi @NimJay since no progress in this issue can I get assigned to this issue. I'll be happy to work on this. @aarushisoni are you still working on this?
Hi @NimJay is someone working on this issue? i would like give it a shot c:
Hi @andresmc98, :)
I don't think anyone was working on this. Correct my if I'm wrong, @TonyBhargav. :) I just assigned it to you (@andresmc98).
Just a heads-up: please see before starting any work:
Thank you all, for your interest in contributing.
Thank you, so i'll checks the docs first
Hi @NimJay, can you assign this one to me? I've already made relevant changes to both index.js and server.js files on my local. I want to confirm the changes with you.
@NimJay, I just noticed that /src/currencyservice/server.js already has pino implemented, can you confirm?
@NimJay, I've raised a PR: https://github.com/GoogleCloudPlatform/microservices-demo/pull/2262 Can you look into it and let me know if I'm missing something?
@NimJay, I've already committed my changes can you look into it