metacontroller icon indicating copy to clipboard operation
metacontroller copied to clipboard

Add flag to set custom CA

Open bakins opened this issue 7 years ago • 4 comments

I generally run all my services inside the cluster with certificates signed by an internal CA. I want to run my metacontroller hooks the same way. This PR adds a flag to allow adding a custom CA for certificate verification.

I wound up having to touch a lot more code that I liked. Ultimately, I needed to use a custom http.Client in hooks/webhook.go, but I need to pass that through from main.go. I'm not sure this is the best approach, but wanted to offer it up for discussion.

Thanks for the project! This allowed me to greatly simplify some custom controllers I maintain at my day job.

bakins avatar May 25 '18 12:05 bakins

@enisoc Thanks for the feedback. I've been traveling, but will address these soon.

bakins avatar Jun 11 '18 21:06 bakins

Looking forward to this change -- we will def use this. Some basic docs on how to set up would be helpful too.

bsherrod avatar Jan 18 '19 19:01 bsherrod

@bsherrod I think the original author of this PR wasn't able to finish it. I left it open as bait to see if anyone else wanted the same thing. Would you be interested in helping to clone this and get it finished? I'm focusing on integration tests for now and may not get to this for a while otherwise.

enisoc avatar Jan 18 '19 21:01 enisoc

I'll see if someone on my team can take it.

bsherrod avatar Jan 19 '19 02:01 bsherrod