magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

App Check DeviceCheck provider

Open rainshen49 opened this issue 1 year ago • 8 comments

Add support for Apple's DeviceCheck provider for App Check.

Part of https://github.com/hashicorp/terraform-provider-google/issues/17095

Release Note Template for Downstream PRs (will be copied)

`google_firebase_app_check_device_check_config`

rainshen49 avatar Feb 13 '24 20:02 rainshen49

/gcbrun

melinath avatar Feb 13 '24 21:02 melinath

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 809 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 7 files changed, 809 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Feb 13 '24 21:02 modular-magician

Tests analytics

Total tests: 9 Passed tests: 6 Skipped tests: 0 Affected tests: 3

Click here to see the affected service packages
  • firebaseappcheck

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigFullExample|TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigMinimalExample|TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigUpdate

Get to know how VCR tests work

modular-magician avatar Feb 13 '24 21:02 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigFullExample[Debug log] TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigMinimalExample[Debug log] TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Feb 13 '24 21:02 modular-magician

/gcbrun

melinath avatar Feb 16 '24 19:02 melinath

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 701 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 7 files changed, 701 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Feb 16 '24 19:02 modular-magician

Tests analytics

Total tests: 14 Passed tests: 13 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • firebaseappcheck

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigUpdate

Get to know how VCR tests work

modular-magician avatar Feb 16 '24 20:02 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Feb 16 '24 20:02 modular-magician

/gcbrun

melinath avatar Mar 06 '24 17:03 melinath

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 725 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 7 files changed, 725 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Mar 06 '24 17:03 modular-magician

Tests analytics

Total tests: 18 Passed tests: 16 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • firebaseappcheck

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigFullExample|TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigUpdate

Get to know how VCR tests work

modular-magician avatar Mar 06 '24 17:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigFullExample[Debug log] TestAccFirebaseAppCheckDeviceCheckConfig_firebaseAppCheckDeviceCheckConfigUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Mar 06 '24 17:03 modular-magician

Please don't approve/merge yet. Let me fix the same issue as https://github.com/GoogleCloudPlatform/magic-modules/pull/10120. UPDATE: done

rainshen49 avatar Mar 06 '24 18:03 rainshen49

/gcbrun

melinath avatar Mar 06 '24 22:03 melinath

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 576 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 7 files changed, 733 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Mar 06 '24 22:03 modular-magician

Tests analytics

Total tests: 18 Passed tests: 18 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • firebaseappcheck

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

modular-magician avatar Mar 06 '24 22:03 modular-magician