magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Change google_network_security_tls_inspection_policy to ga

Open paulomarquescit opened this issue 1 year ago • 4 comments

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/17247 This PR sends the 'google_network_security_tls_inspection_policy' resource from beta version to GA

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that the resource and his fields wich I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_network_security_tls_inspection_policy` (GA)
networksecurity: promoted `tls_inspection_policy` field in `google_network_security_gateway_security_policy` to GA

paulomarquescit avatar Feb 12 '24 13:02 paulomarquescit

/gcbrun

shuyama1 avatar Feb 12 '24 21:02 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1001 insertions(+), 7 deletions(-)) Terraform Beta: Diff ( 3 files changed, 3 insertions(+), 5 deletions(-))

modular-magician avatar Feb 12 '24 21:02 modular-magician

Tests analytics

Total tests: 33 Passed tests: 31 Skipped tests: 1 Affected tests: 1

Click here to see the affected service packages
  • networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkSecurityTlsInspectionPolicy_networkSecurityTlsInspectionPolicyBasicExample

Get to know how VCR tests work

modular-magician avatar Feb 12 '24 21:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccNetworkSecurityTlsInspectionPolicy_networkSecurityTlsInspectionPolicyBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 12 '24 21:02 modular-magician

@paulomarquescit @shuyama1 actually, this should be already included in this PR.

Also, I think the depending resources of this test are still beta, so I preferred to move the resource only to GA, but tests are still full beta for now. We can always double check later if also the dependent resources should be upgraded. @shuyama1 what do you think?

LucaPrete avatar May 02 '24 23:05 LucaPrete

@paulomarquescit @shuyama1 actually, this should be already included in this PR.

Also, I think the depending resources of this test are still beta, so I preferred to move the resource only to GA, but tests are still full beta for now. We can always double check later if also the dependent resources should be upgraded. @shuyama1 what do you think?

Thanks for the update. Do we have other GA tests that cover the resource, or if resource is proven to work fine locally with existing dependent resources in GA provider? Basically, we'll just need to make sure we can confirm the resource behaves as expected with the GA endpoint before promoting it to GA and upgrading the dependent resources could happen in a separate PR.

shuyama1 avatar May 02 '24 23:05 shuyama1

@shuyama1 sorry...I noticed those other resources went to GA as well. Now in my PR everything is GA. I think we can abandon this one.

LucaPrete avatar May 03 '24 08:05 LucaPrete

@shuyama1 sorry...I noticed those other resources went to GA as well. Now in my PR everything is GA. I think we can abandon this one.

Sounds good! Thank you @LucaPrete!

@paulomarquescit Feel free to close this PR as the change will be in https://github.com/GoogleCloudPlatform/magic-modules/pull/10583. Thanks for working on it!

shuyama1 avatar May 03 '24 16:05 shuyama1

@paulomarquescit, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar May 29 '24 09:05 github-actions[bot]

@paulomarquescit, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jun 10 '24 09:06 github-actions[bot]

@paulomarquescit, this PR is being closed due to inactivity.

github-actions[bot] avatar Jun 12 '24 09:06 github-actions[bot]