magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

TeamCity: Refactor config tests

Open SarahFrench opened this issue 1 year ago • 8 comments

Release Note Template for Downstream PRs (will be copied)


SarahFrench avatar Feb 09 '24 16:02 SarahFrench

I'm going to keep this as draft until the GHA implemented in https://github.com/GoogleCloudPlatform/magic-modules/pull/9954 is available to help reviewers

SarahFrench avatar Feb 09 '24 16:02 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 42 insertions(+), 61 deletions(-))

modular-magician avatar Feb 09 '24 16:02 modular-magician

Rebased to include https://github.com/GoogleCloudPlatform/magic-modules/pull/9954

SarahFrench avatar Feb 16 '24 13:02 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 44 insertions(+), 63 deletions(-))

modular-magician avatar Feb 16 '24 13:02 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 44 insertions(+), 63 deletions(-))

modular-magician avatar Feb 16 '24 14:02 modular-magician

I'm going to wait for https://github.com/GoogleCloudPlatform/magic-modules/pull/10003 to be merged and rebase again 🤦

SarahFrench avatar Feb 16 '24 15:02 SarahFrench

Yay, after the last rebase the TeamCity config check is running as expected 🎉

SarahFrench avatar Feb 16 '24 17:02 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 44 insertions(+), 63 deletions(-))

modular-magician avatar Feb 16 '24 17:02 modular-magician

Rebased to include https://github.com/GoogleCloudPlatform/magic-modules/pull/10025, addressed merge conflicts and used this PR's work to refactor the new tests added

SarahFrench avatar Mar 01 '24 11:03 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 48 insertions(+), 80 deletions(-))

modular-magician avatar Mar 01 '24 11:03 modular-magician