magic-modules
magic-modules copied to clipboard
GoogleCloudPlatform
Allow vcenter_network to be set
https://github.com/hashicorp/terraform-provider-google/issues/16821
Release Note Template for Downstream PRs (will be copied)
`google_gkeonprem_vmware_cluster` allow `vcenter_network` to be set
Hello! I am a robot. It looks like you are a: ~Community Contributor~ Googler ~Core Contributor~. Tests will run automatically.
@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 5 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 3 files changed, 5 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 20
Passed tests 18
Skipped tests: 1
Affected tests: 1
Click here to see the affected service packages
- gkeonprem
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample[Debug log]
Rerun these tests in REPLAYING mode to catch issues
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test
Just want to confirm, is this a field that can be specified by user? Looks like the API doc still shows it as an output-only field https://cloud.google.com/anthos/clusters/docs/on-prem-api/reference/rest/v1/projects.locations.vmwareClusters#vmwarenetworkconfig
Just want to confirm, is this a field that can be specified by user? Looks like the API doc still shows it as an output-only field https://cloud.google.com/anthos/clusters/docs/on-prem-api/reference/rest/v1/projects.locations.vmwareClusters#vmwarenetworkconfig
Thanks for checking! Yes, we need to update the public doc for on-prem API as well. We are drafting the changes in parallel. Here is the CRD docs for the field which shows the field can be specified but immutable. https://cloud.google.com/anthos/clusters/docs/on-prem/latest/how-to/user-cluster-configuration-file#network-vcenter-networkname-field
@shuyama1 could you please help take another look at this PR when you get a chance? Thanks!
@naitianliu-google Sorry, I didn't realize it's waiting on my review since it's not showing up on my review list. Taking a review now. Thanks for the ping.
@naitianliu-google Sorry, I didn't realize it's waiting on my review since it's not showing up on my review list. Taking a review now. Thanks for the ping.
@shuyama1 Thanks for taking time to review this PR. Please let me know if anything else needs to be changed.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 5 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 3 files changed, 5 insertions(+), 1 deletion(-))
Tests analytics
Total tests: 20
Passed tests 19
Skipped tests: 1
Affected tests: 0
Click here to see the affected service packages
- gkeonprem
$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$ View the build log