magic-modules
magic-modules copied to clipboard
Add explicity dependency on IAM in PubSub acc test config to fix `TestAccPubsubSubscriptionBigQuery_update` failures
This PR fixes some failures in TestAccPubsubSubscriptionBigQuery_update
where IAM permissions aren't present at the time when the subscription is being created:
------- Stdout: -------
=== RUN TestAccPubsubSubscriptionBigQuery_update
=== PAUSE TestAccPubsubSubscriptionBigQuery_update
=== CONT TestAccPubsubSubscriptionBigQuery_update
vcr_utils.go:152: Step 1/4 error: Error running apply: exit status 1
Error: Error creating Subscription: googleapi: Error 403: The caller does not have permission
with google_pubsub_subscription.foo,
on terraform_plugin_test.tf line 41, in resource "google_pubsub_subscription" "foo":
41: resource "google_pubsub_subscription" "foo" {
--- FAIL: TestAccPubsubSubscriptionBigQuery_update (23.87s)
FAIL
Release Note Template for Downstream PRs (will be copied)
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 1 file changed, 9 insertions(+), 4 deletions(-)) Terraform Beta: Diff ( 1 file changed, 9 insertions(+), 4 deletions(-))
Tests analytics
Total tests: 42
Passed tests 41
Skipped tests: 1
Affected tests: 0
Click here to see the affected service packages
- pubsub
$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$ View the build log
Hi @slevenick , could you please review?
Thanks!