magic-modules
magic-modules copied to clipboard
GoogleCloudPlatform
Adding Parallelstore Beta Service Provider
Adding Parallelstore Beta Service Provider
Added Instance.yaml and product.yaml in mmv1/products/parallelstore/ Added Example in mmv1/templates/terraform/examples/ Added test in mmv1/third_party/terraform/services/parallelstore/ with basic and update
`google_parallelstore_instance`
Hello! I am a robot. It looks like you are a: Community Contributor ~Googler~ ~Core Contributor~. Tests will require approval to run.
@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 10 files changed, 459 insertions(+)) Terraform Beta: Diff ( 14 files changed, 1355 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_parallelstore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_parallelstore_instance" "primary" {
reserved_ip_range = # value needed
}
Tests analytics
Total tests: 3419
Passed tests 3066
Skipped tests: 349
Affected tests: 4
Click here to see the affected service packages
all service packages are affected
Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy|TestAccParallelstoreInstance_parallelstoreInstanceBasicExample|TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update|TestAccSpannerInstanceIamPolicy
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]
Rerun these tests in REPLAYING mode to catch issues
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample[Error message] [Debug log]
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
The errors above are
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample
Error: Unsupported block type
on terraform_plugin_test.tf line 7, in resource "google_parallelstore_instance" "instance":
7: network_config {
Blocks of type "network_config" are not expected here.
Assuming that the config in the acceptance tests is correct, the network config field is missing from mmv1/products/parallelstore/Instance.yaml.
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update
Error 403: Parallelstore API has not been used in project ....
I'll fix this - the GCP project we use for automated testing of PRs needs the API to be enabled
Hey @SarahFrench !
network_config is incorrect, i have removed that in the handwritten test and from Instance.yaml, but then in auto generated test,
It still adds this config, not sure why.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 10 files changed, 457 insertions(+)) Terraform Beta: Diff ( 14 files changed, 1351 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_parallelstore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_parallelstore_instance" "primary" {
reserved_ip_range = # value needed
}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 208 insertions(+)) Terraform Beta: Diff ( 14 files changed, 1351 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_parallelstore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_parallelstore_instance" "primary" {
reserved_ip_range = # value needed
}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 199 insertions(+)) Terraform Beta: Diff ( 14 files changed, 1351 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 116 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_parallelstore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_parallelstore_instance" "primary" {
reserved_ip_range = # value needed
}
Tests analytics
Total tests: 3419
Passed tests 3067
Skipped tests: 349
Affected tests: 3
Click here to see the affected service packages
all service packages are affected
Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy|TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update|TestAccParallelstoreInstance_parallelstoreInstanceBasicExample
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
Rerun these tests in REPLAYING mode to catch issues
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update[Error message] [Debug log]
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hi @unnatinadupalli - I wasn't aware earlier that Parallelstore is in private preview. I'm afraid we need to reject (or at least pause) this PR until the product is publicly available.
Hey Sarah! Paralllelstore isin't in private preview, we are going to be in allowlisted GA. For which this API is bring promoted.
Hey! I saw on https://cloud.google.com/parallelstore that "Parallelstore is in private preview. Contact your account manager or sales for pricing.", Is the change to allowlisted GA imminent? We wouldn't want to add this to the provider unless everyone was able to use the service.
I've been told there's an internal discussion about this - I'm going to wait for directions from the provider team about the outcome.
Summary of the internal discussion: Provided we're using v1beta endpoints (which this PR does appear to do), we're fine to move forward with this into google-beta despite the access lists. Context in b/325292456 (googlers). @SarahFrench if you need assistance w/ access lists or just a Googler to take over review, let me know.
Thanks for addressing those last review comments. Once we get the automated tests running I'll review more in depth.
I'm seeing issues with the checks again, but a different issue than I noted before in this comment. The issue mentioned before referenced the issue fixed in this PR, but the failure is referencing an issue I experienced there too. In that case I reran the checks again and it worked.
Because of that, I'll just re-run checks on this PR : /gcbrun
It's still failing - I'll share internally with the person investigating this problem
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 2 files changed, 235 insertions(+))
google-beta provider: Diff ( 13 files changed, 1440 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_parallelstore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_parallelstore_instance" "primary" {
reserved_ip_range = # value needed
}
Tests analytics
Total tests: 3554
Passed tests 3183
Skipped tests: 368
Affected tests: 3
Click here to see the affected service packages
all service packages are affected
Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update|TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update|TestAccParallelstoreInstance_parallelstoreInstanceBasicExample
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Debug log]
Rerun these tests in REPLAYING mode to catch issues
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update[Error message] [Debug log]
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
I realised without public API docs for this service it's hard for me to double check the YAML for fields - is there a way for me to get access to that? If not I may need to hand over review to a Googler.
The acceptance tests are currently failing due to and error returned during the create operation. The provider polls for status of the operation and after approximately 10minutes there's an error code 13. I'm afraid I don't have a way to investigate that further:
Error: Error waiting to create Instance: Error waiting for Creating Instance: Error code 13, message: an internal error has occurred
Hey @SarahFrench, I don't think we have a way to give you access to our protos as of now. Perhaps it is better to hand off the pr to a googler.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 2 files changed, 235 insertions(+))
google-beta provider: Diff ( 13 files changed, 1440 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 116 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_parallelstore_instance (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_parallelstore_instance" "primary" {
reserved_ip_range = # value needed
}
Tests analytics
Total tests: 3556
Passed tests 3186
Skipped tests: 367
Affected tests: 3
Click here to see the affected service packages
all service packages are affected
Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy|TestAccParallelstoreInstance_parallelstoreInstanceBasicExample|TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample[Debug log]
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample_update[Debug log]
Rerun these tests in REPLAYING mode to catch issues
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccDataprocClusterIamPolicy[Error message] [Debug log]
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.
Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log or the debug log for each test