magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

docs: explain more aboutvalue_extractor

Open sahya opened this issue 1 year ago • 3 comments

Summary of changes:

  • Added clarification that value_extractor is required for distribution logs-based metrics
  • Provided examples for EXTRACT(field) and REGEXP_EXTRACT(field, regex)
  • Clarified the arguments for value_extractor - "field" and "regex"
  • Mentioned the requirement of correct regular expression for the "regex" argument Highlighted the requirement of bucket_options and value_extractor for DISTRIBUTION value type logs-based metrics

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • [ ] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


sahya avatar Jan 04 '24 22:01 sahya

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 04 '24 22:01 google-cla[bot]

Hello! I am a robot. It looks like you are a: Community Contributor ~Googler~ ~Core Contributor~. Tests will require approval to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician avatar Jan 04 '24 22:01 modular-magician

Related https://github.com/hashicorp/terraform-provider-google/pull/14339

sahya avatar Jan 04 '24 22:01 sahya