GoogleCloudPlatform
Add gcs volume type to Cloud Run v2 beta provider
Add support for mounting GCS volumes in Cloud Run v2 Jobs and Services, in the beta provider.
This is a new feature in Cloud Run.
Release Note Template for Downstream PRs (will be copied)
cloudrunv2: support mounting Cloud Storage buckets using GCSFuse (beta).
Hello! I am a robot. It looks like you are a: Community Contributor ~Googler~ ~Core Contributor~. Tests will require approval to run.
@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 30 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 6 files changed, 386 insertions(+), 1 deletion(-)) TF Conversion: Diff ( 2 files changed, 82 insertions(+))
Tests analytics
Total tests: 35
Passed tests 33
Skipped tests: 0
Affected tests: 2
Click here to see the affected service packages
- cloudrunv2
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCloudRunV2Service_cloudrunv2ServiceGcsVolume|TestAccCloudRunV2Job_cloudrunv2JobWithGcsUpdate
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Service_cloudrunv2ServiceGcsVolume[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobWithGcsUpdate[Debug log]
Rerun these tests in REPLAYING mode to catch issues
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test
@bskaplan note that The feature is available in the GA API as cloudrunv2 does not have a beta API: so the feature is available in both the beta and the ga provider.
You have to choose launch_stage BETA to get it to run.
@mvanholsteijn it's supported by the GA API, but I'm not adding the fields to the GA Terraform provider. I did update the docs to mention that it requires setting the launch stage and execution environment for services.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 30 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 6 files changed, 386 insertions(+), 1 deletion(-)) TF Conversion: Diff ( 2 files changed, 82 insertions(+))
Tests analytics
Total tests: 35
Passed tests 35
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- cloudrunv2
$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$ View the build log
Drive-by comment: Re-running tests since the unit test failure is due to a flake that's been resolved on main. /gcbrun
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 30 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 6 files changed, 386 insertions(+), 1 deletion(-)) TF Conversion: Diff ( 2 files changed, 82 insertions(+))
Tests analytics
Total tests: 35
Passed tests 35
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- cloudrunv2
$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$ View the build log
Ping on this. https://github.com/GoogleCloudPlatform/magic-modules/pull/9728 added support for GCS in services, so now this PR is adding support to Jobs as well as adding tests for the feature.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 17 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 6 files changed, 287 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))
Tests analytics
Total tests: 39
Passed tests: 39
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- cloudrunv2
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log