magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Update storage_bucket.html.markdown public_access_prevention

Open 880831ian opened this issue 1 year ago • 8 comments

Release Note Template for Downstream PRs (will be copied)

After testing, it was found that when using Google Storage to create a Bucket, the default value of public_access_prevention is enforced, not inherited.

截圖 2023-12-22 下午4 44 04

880831ian avatar Dec 22 '23 08:12 880831ian

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 22 '23 08:12 google-cla[bot]

Hello! I am a robot. It looks like you are a: Community Contributor ~Googler~ ~Core Contributor~. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician avatar Dec 22 '23 08:12 modular-magician

@rileykarson Hi, can you check the PR for me? Thanks!

880831ian avatar Dec 26 '23 02:12 880831ian

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 22 '24 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 29 '24 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 05 '24 09:06 github-actions[bot]

/gcbrun

rileykarson avatar Jun 06 '24 21:06 rileykarson

@880831ian, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jun 25 '24 09:06 github-actions[bot]

@880831ian, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

/gcbrun

rileykarson avatar Jul 09 '24 18:07 rileykarson

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician avatar Jul 10 '24 17:07 modular-magician

thank you !

880831ian avatar Jul 10 '24 17:07 880831ian