magic-modules
magic-modules copied to clipboard
bigquery conn - add kms support
Release Note Template for Downstream PRs (will be copied)
bigqueryconnection: add support for `kmsKeyName`
Hello! I am a robot. It looks like you are a: Community Contributor ~Googler~ ~Core Contributor~. Tests will require approval to run.
@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 129 insertions(+)) Terraform Beta: Diff ( 3 files changed, 129 insertions(+)) TF Conversion: Diff ( 1 file changed, 10 insertions(+)) TF OiCS: Diff ( 4 files changed, 125 insertions(+))
Tests analytics
Total tests: 3300
Passed tests 2962
Skipped tests: 337
Affected tests: 1
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
@DrFaust92, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 14 days.
This notification can be disabled with the disable-automatic-closure
label.
@DrFaust92, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 2 weekdays.
This notification can be disabled with the disable-automatic-closure
label.
@DrFaust92, this PR is being closed due to inactivity.